Skip to content

feat(replay): Capture replay mutation breadcrumbs & add experiment - #7568

Merged
mydea merged 5 commits into
developfrom
fn/mutation-size
Mar 24, 2023
Merged

feat(replay): Capture replay mutation breadcrumbs & add experiment#7568
mydea merged 5 commits into
developfrom
fn/mutation-size

Conversation

@mydea

@mydeamydea commented Mar 22, 2023•
edited by billyvg
Loading

Copy link
Copy Markdown
Member

Adds _experiments.mutationLimit to experiment with this.
This will result in any mutations with more than the given amount of mutations will trigger a full snapshot instead of an incremental one with a lot of mutations.

Closes#7530
Closes#7529

@mydea
mydea requested review from Lms24 and billyvgMarch 22, 2023 14:01
@mydeamydea self-assigned this Mar 22, 2023
mydea
mydea commented Mar 22, 2023
View reviewed changes
Comment threadpackages/replay/src/replay.ts Outdated
billyvg
billyvg reviewed Mar 22, 2023
View reviewed changes

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some small 🚲 🏠

Comment threadpackages/replay/src/replay.ts Outdated
Comment threadpackages/replay/src/replay.ts Outdated
Comment threadpackages/replay/src/replay.ts Outdated
@github-actions

github-actionsBot commented Mar 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.57 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified)64.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.13 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)56.58 KB (0%)
@sentry/browser - Webpack (gzipped + minified)21.59 KB (0%)
@sentry/browser - Webpack (minified)71.66 KB (0%)
@sentry/react - Webpack (gzipped + minified)21.61 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified)51.88 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)27.93 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.1 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.37 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.44 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)62.59 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.1 KB (+0.07% 🔺)

@mydea

mydea commented Mar 22, 2023

Copy link
Copy Markdown
MemberAuthor

I addressed the PR feedback @billyvg !

billyvg
billyvg approved these changes Mar 22, 2023
View reviewed changes

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@mydea
mydeaforce-pushed the fn/mutation-size branch 4 times, most recently from 878f9a8 to c542a36CompareMarch 24, 2023 09:24
@mydea
mydea merged commit a2103f3 into developMar 24, 2023
@mydea
mydea deleted the fn/mutation-size branch March 24, 2023 13:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@Lms24Lms24Lms24 approved these changes

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add experiment for large mutations to use full snapshot Removing experiment for adding breadcrumbs for large mutations

3 participants

@mydea@billyvg@Lms24