Skip to content

fix(core): Ensure ignoreErrors only applies to error events - #7573

Merged
mydea merged 1 commit into
developfrom
fn/ignore-errors
Mar 23, 2023
Merged

fix(core): Ensure ignoreErrors only applies to error events#7573
mydea merged 1 commit into
developfrom
fn/ignore-errors

Conversation

@mydea

Copy link
Copy Markdown
Member

Noticed that actually currently we filter any type of event here.

We should handle transactions separately (TBD).

@mydea
mydea requested review from AbhiPrasad and Lms24March 22, 2023 16:17
@mydeamydea self-assigned this Mar 22, 2023
@github-actions

github-actionsBot commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.57 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)64.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.13 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)56.58 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.59 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified)71.66 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified)21.61 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)51.85 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)27.9 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.08 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.3 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)38.36 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)62.49 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.04 KB (+0.01% 🔺)

@mydeamydea changed the title fix: Ensure ignoreErrors only applies to error eventsfix(core): Ensure ignoreErrors only applies to error eventsMar 23, 2023
@mydea
mydea enabled auto-merge (squash) March 23, 2023 07:55
@mydea
mydea merged commit 0a1a567 into developMar 23, 2023
@mydea
mydea deleted the fn/ignore-errors branch March 23, 2023 08:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad