Uh oh!
There was an error while loading. Please reload this page.
fix(core): Log warning when tracing extensions are missing - #7601
Merged
AbhiPrasad merged 9 commits intoApr 11, 2023
Conversation
Uh oh!
There was an error while loading. Please reload this page.
mydea
reviewed
Mar 27, 2023
Uh oh!
There was an error while loading. Please reload this page.
AbhiPrasad
approved these changes
Mar 27, 2023
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Leaving for @mydea to confirm
AbhiPrasad
commented
Mar 29, 2023
Contributor
Actually @timfish could we change this into a |
timfish
commented
Mar 29, 2023
CollaboratorAuthor
Yeah I suppose people could already be relying on |
AbhiPrasad
commented
Mar 29, 2023
Contributor
We fix this properly in v8! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating away from
@sentry/tracing, we lose the side-effects that are now added viaaddTracingExtensions().When calling
startTransaction()without tracing extensions, it returnsundefinedwhich doesn't match the types. This can result in errors elsewhere that do not help you fix the issue.