Skip to content

perf(build): Use @rollup/plugin-typescript for es5 builds - #7665

Merged
AbhiPrasad merged 2 commits into
developfrom
abhi-speed-up-es5
Mar 30, 2023
Merged

perf(build): Use @rollup/plugin-typescript for es5 builds#7665
AbhiPrasad merged 2 commits into
developfrom
abhi-speed-up-es5

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

rollup-plugin-typescript2 is way too slow. Using @rollup/plugin-typescript decreases the build times by 95% as a result.

Confirmed with diff checker that this does not change bundle output value.

Before:

yarn run v1.22.19
$ JS_VERSION=es5 rollup -c rollup.bundle.config.js
src/index.bundle.ts → build...
created build in 27.4s
src/index.bundle.ts → build...
created build in 26.9s
src/index.bundle.ts → build...
created build in 26.5s
src/index.bundle.tracing.ts → build...
created build in 39.7s
src/index.bundle.tracing.ts → build...
created build in 40.2s
src/index.bundle.tracing.ts → build...
created build in 39.6s
✨ Done in 201.25s.

After:

yarn run v1.22.19
$ JS_VERSION=es5 rollup -c rollup.bundle.config.js
src/index.bundle.ts → build...
created build in 2.7s
src/index.bundle.ts → build...
created build in 867ms
src/index.bundle.ts → build...
created build in 794ms
src/index.bundle.tracing.ts → build...
created build in 2s
src/index.bundle.tracing.ts → build...
created build in 1.1s
src/index.bundle.tracing.ts → build...
created build in 1.1s
✨ Done in 9.27s.

@AbhiPrasadAbhiPrasad self-assigned this Mar 30, 2023

@mydeamydea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah!

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) March 30, 2023 09:18
@AbhiPrasad
AbhiPrasad merged commit 65c44ec into developMar 30, 2023
@AbhiPrasad
AbhiPrasad deleted the abhi-speed-up-es5 branch March 30, 2023 09:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad@mydea@Lms24