Skip to content

ci: Make E2E tests required & check for PRs against master - #7670

Merged
mydea merged 3 commits into
developfrom
fn/ci-check
Mar 30, 2023
Merged

ci: Make E2E tests required & check for PRs against master#7670
mydea merged 3 commits into
developfrom
fn/ci-check

Conversation

@mydea

Copy link
Copy Markdown
Member

This makes the E2E tests required, and adds a job that checks if a branch is opened against master.

Opening this against master first to check if it works...

@mydeamydea self-assigned this Mar 30, 2023
@github-actions

github-actionsBot commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

⚠️ This PR is opened against master. You probably want to open it against develop.

@mydea

Copy link
Copy Markdown
MemberAuthor

Note: I also verified it does not re-create the commit if you keep pushing to the same PR. It should only add it once.

@mydea
mydea changed the base branch from master to developMarch 30, 2023 11:50
@mydea
mydea marked this pull request as ready for review March 30, 2023 11:50
Comment thread.github/workflows/build.yml

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea

Copy link
Copy Markdown
MemberAuthor

I updated this to:

  • ensure we do not run the flaky detector for PRs against master/develop
  • ensure the flaky detector scales to how many tests it detects. It will automatically reduce the amount of runs per test if more tests are in a single PR.

Comment thread.github/workflows/build.yml Outdated
Comment thread.github/workflows/build.yml
@AbhiPrasad

Copy link
Copy Markdown
Contributor

woooooooops

@AbhiPrasadAbhiPrasad reopened this Mar 30, 2023
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.62 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified)64.4 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.15 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)56.78 KB (0%)
@sentry/browser - Webpack (gzipped + minified)21.53 KB (0%)
@sentry/browser - Webpack (minified)72 KB (0%)
@sentry/react - Webpack (gzipped + minified)21.55 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)52.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)28.21 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.4 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.74 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)63.45 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.49 KB (-0.01% 🔽)

@mydea
mydea merged commit 1c009fa into developMar 30, 2023
@mydea
mydea deleted the fn/ci-check branch March 30, 2023 15:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@AbhiPrasad@Lms24