Skip to content

fix(ember): Ensure only one client is created & Replay works - #7712

Merged
mydea merged 3 commits into
developfrom
fn/ember-replay
Apr 4, 2023
Merged

fix(ember): Ensure only one client is created & Replay works#7712
mydea merged 3 commits into
developfrom
fn/ember-replay

Conversation

@mydea

@mydeamydea commented Apr 3, 2023

Copy link
Copy Markdown
Member

This uses the new addIntegration API to add browser tracing, which means we do not need to call Sentry.init() twice, which lead to issues as replay relies on the client remaining consistent.

Fixes#7640

@mydea
mydea requested review from a team and k-fishApril 3, 2023 11:00
@mydeamydea self-assigned this Apr 3, 2023
@mydea
mydea requested review from AbhiPrasad and lforst and removed request for a teamApril 3, 2023 11:00

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about Ember-specifics but the change makes sense to me.

Comment threadpackages/ember/addon/instance-initializers/sentry-performance.ts Outdated
@github-actions

github-actionsBot commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.77 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)64.88 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified)57.2 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.83 KB (0%)
@sentry/browser - Webpack (minified)68.17 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.86 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)48.68 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)28.36 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.53 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.87 KB (0%)
@sentry/replay - Webpack (gzipped + minified)38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)63.58 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.62 KB (0%)

mydea added 3 commits April 4, 2023 11:21
With the new `addIntegration` API, we don't need to create multiple clients anymore, which also potentially broke replays.
@mydea
mydea merged commit d92114b into developApr 4, 2023
@mydea
mydea deleted the fn/ember-replay branch April 4, 2023 10:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BaseClient._hooks are deleted when initializing @sentry/ember in Chrome

2 participants

@mydea@Lms24