Uh oh!
There was an error while loading. Please reload this page.
feat(node): Replace usages of domain run and bind with runWithHub - #7745
Closed
timfish wants to merge 1 commit into
Closed
feat(node): Replace usages of domain run and bind with runWithHub#7745timfish wants to merge 1 commit into
run and bind with runWithHub#7745timfish wants to merge 1 commit into
Conversation
timfish
marked this pull request as ready for review
April 4, 2023 20:46
9 tasks
run and bind with runWithHubrun and bind with runWithHubAbhiPrasad
commented
Apr 5, 2023
Contributor
Can we do this after we make the necessary changes in core? Add the hub manager abstraction first? |
timfish
commented
Apr 5, 2023
CollaboratorAuthor
Almost certainly, although this was listed as the first task! I'll give it a go. |
AbhiPrasad
commented
Apr 5, 2023
Contributor
Ah yeah that was just a slip up I think - let's keep this open though since it is what we need to do! |
timfish
commented
Apr 6, 2023
CollaboratorAuthor
Closing in favour of a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #7691
The plan is to to make async context scope tracking configurable and the first step is to have the existing domain solution working from a single function.