Uh oh!
There was an error while loading. Please reload this page.
feat(node): Migrate to domains used through AsyncContextStrategy - #7779
Conversation
AbhiPrasad
left a comment
There was a problem hiding this comment.
node sdk index is now side effect free :)
timfish
commented
Apr 7, 2023
Ah, just noticed I still have some domain usages to remove from serverless! |
lforst
commented
Apr 7, 2023
This makes me so happy :) Speaking of, @timfish would you mind adding a |
AbhiPrasad
commented
Apr 7, 2023
We also need to adjust the test in |
…ish/sentry-javascript into feat/migrate-async-strategy
timfish
commented
Apr 7, 2023
Should we be re-exporting |
lforst
commented
Apr 7, 2023
Shouldn't we be exporting this API everywhere? Doesn't have to be right now but at some point I think we should, right? |
AbhiPrasad
commented
Apr 7, 2023
Yup we'll need to re-export this API, since this is how we are going to tell people to do isolation when they manually instrument. |
Uh oh!
There was an error while loading. Please reload this page.
timfish
commented
Apr 7, 2023
I might change the name of the |
And this is why you don't do early morning code review 😭 - it is there, just skipped the file completely! |
This PR:
domain.create().bind/runwithrunWithAsyncContextdomain.activehack from the Next.jsinitsince domains are now not created byrunWithAsyncContextuntil afterinitNoderunWithAsyncContextfrom@sentry/node