Skip to content

feat(replay): Add getReplayId() method - #7822

Merged
mydea merged 2 commits into
developfrom
fn/getSessionId
Apr 12, 2023
Merged

feat(replay): Add getReplayId() method#7822
mydea merged 2 commits into
developfrom
fn/getSessionId

Conversation

@mydea

@mydeamydea commented Apr 12, 2023

Copy link
Copy Markdown
Member

This adds a public getReplayId() method to the replay integration to get the ID of the ongoing session.

Closes#7795

@mydea
mydea requested review from Lms24 and billyvgApril 12, 2023 10:50
@mydeamydea self-assigned this Apr 12, 2023
@github-actions

github-actionsBot commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.98 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)65.56 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.53 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)58 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.13 KB (+0.07% 🔺)
@sentry/browser - Webpack (minified)68.95 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped + minified)21.15 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)48.95 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)28.54 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.77 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.93 KB (+0.04% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.86 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)63.82 KB (+0.05% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.86 KB (+0.05% 🔺)

@pckilgore

Copy link
Copy Markdown

Doesn't directly address my issue because I still manually need to construct URLs with the IDs, but helpful nonetheless, thank you!

@mydeamydea changed the title feat(replay): Add getSessonId() methodfeat(replay): Add getReplayId() methodApr 12, 2023
@mydea

Copy link
Copy Markdown
MemberAuthor

Doesn't directly address my issue because I still manually need to construct URLs with the IDs, but helpful nonetheless, thank you!

Yeah, the idea is to unblock this with a public API (building the URL is tricky as we don't necessarily know about where the UI is hosted etc). To at least enable to do this yourself without using private APIs!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay: method to extract replayId from SDK

3 participants

@mydea@pckilgore@billyvg