Skip to content

fix(tracing): Ensure we use s instead of ms for startTimestamp - #7877

Merged
mydea merged 1 commit into
developfrom
fn/fix-transaction-start
Apr 17, 2023
Merged

fix(tracing): Ensure we use s instead of ms for startTimestamp#7877
mydea merged 1 commit into
developfrom
fn/fix-transaction-start

Conversation

@mydea

Copy link
Copy Markdown
Member

Fixes a bug introduced in #7632 due to assuming timestampWithMs returns a timestamp in ms (which it does not do).

Also replaces all usage of timestampWithMs with timestampInSeconds.

Let's deprecate timestampWithMs in a follow up PR.

Let's deprecate `timestampWithMs` in a follow up PR.
@mydea
mydea requested review from AbhiPrasad and Lms24April 17, 2023 14:02
@mydeamydea self-assigned this Apr 17, 2023
@mydeamydea changed the title fix(tracing): Ensure we use s instead of ms for startTimestampfix(tracing): Ensure we use s instead of ms for startTimestampApr 17, 2023
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.04 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.59 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified)21.19 KB (0%)
@sentry/browser - Webpack (minified)69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified)21.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)49.05 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)28.62 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.85 KB (-0.02% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)45.35 KB (0%)
@sentry/replay - Webpack (gzipped + minified)39.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)64.29 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)57.26 KB (0%)

@mydea
mydea merged commit e3313ad into developApr 17, 2023
@mydea
mydea deleted the fn/fix-transaction-start branch April 17, 2023 15:29
@jeengbe

Copy link
Copy Markdown
Contributor

assuming timestampWithMs returns a timestamp in ms (which it does not do).

😄

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea@jeengbe@Lms24@AbhiPrasad