Uh oh!
There was an error while loading. Please reload this page.
fix(utils): default normalize() to a max. of 100 levels deep instead of Inifnity - #7957
Merged
Conversation
This is to avoid infinite recursion that we cannot detect, e.g. when using dynamic proxies.
mydea
marked this pull request as ready for review
April 26, 2023 07:23
normalize() to a max. of 100 levels deep by defaultnormalize() to a max. of 100 levels deep instead of Inifnitylforst
approved these changes
Apr 26, 2023
Comment on lines
+129
to
+137
| for (let i = 0; i < 99; i++) { | ||
| expect(last).toEqual( | ||
| expect.objectContaining({ | ||
| name: expect.any(String), | ||
| child: expect.any(Object), | ||
| }), | ||
| ); | ||
| last = last.child; | ||
| } |
Contributor
There was a problem hiding this comment.
drastic times call for drastic measures
lforst
commented
Apr 26, 2023
Contributor
We should def put this in the changelog - maybe you can put a note there within this pr under a |
mydea
commented
Apr 26, 2023
MemberAuthor
I added a changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid infinite recursion that we cannot detect, e.g. when using dynamic proxies.
Fixes#7947 (hopefully).