Skip to content

fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593

Merged
Lms24 merged 2 commits into
developfrom
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged

fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom
lms/fix-linkederrors-message-truncation

Conversation

@Lms24

@Lms24Lms24 commented Jul 19, 2023

Copy link
Copy Markdown
Member

As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.

closes#8580

@Lms24
Lms24 requested review from kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions

github-actionsBot commented Jul 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)

@Lms24Lms24 mentioned this pull request Jul 20, 2023
Closed
2 tasks
@Lms24
Lms24 merged commit 7d7b8ad into developJul 21, 2023
@Lms24
Lms24 deleted the lms/fix-linkederrors-message-truncation branch July 21, 2023 06:57
@lforstlforst mentioned this pull request Mar 25, 2025
Merged
lforst pushed a commit that referenced this pull request Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit that referenced this pull request Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors

2 participants

@Lms24@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(utils): Truncate aggregate exception values (LinkedErrors) by Lms24 · Pull Request #8593 · getsentry/sentry-javascript · GitHub
Skip to content
fix(utils): Truncate aggregate exception values (LinkedErrors) - #8593
Merged
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Jul 21, 2023
Merged
fix(utils): Truncate aggregate exception values (LinkedErrors)#8593
Lms24 merged 2 commits into
developfrom 
lms/fix-linkederrors-message-truncation
Conversation
@Lms24
@Lms24Lms24
commented
Jul 19, 2023

Copy link


Copy Markdown

Member
As reported in #8580, aggregate exceptions' exception.value strings weren't truncated correctly in our event preparation pipeline. The tricky part here is that the LinkedErrors integration adds the linked/child exceptions to the event in an event processor which is applied only after we truncate the original event. Hence, we need to also truncate the values in the event processor itself.
closes#8580
@Lms24
Lms24
requested review from
kamilogorek and mydeaJuly 19, 2023 16:00
@github-actions
github-actionsBot
commented
Jul 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)21.99 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)69.25 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)20.33 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)60.48 KB (+0.17% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.95 KB (+0.21% 🔺)
@sentry/browser - Webpack (minified)71.63 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped + minified)21.96 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)50.83 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)30.37 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)28.25 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)49.44 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified)43.16 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)69.61 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.88 KB (+0.08% 🔺)
@Lms24Lms24
mentioned this pull request
Jul 20, 2023
 Closed

2 tasks
@Lms24
Lms24
merged commit 7d7b8ad
into
developJul 21, 2023
@Lms24
Lms24
deleted the

lms/fix-linkederrors-message-truncation

branch
July 21, 2023 06:57
@lforstlforst
mentioned this pull request
Mar 25, 2025
 Merged

lforst pushed a commit
that referenced
this pull request
Mar 31, 2025
Luca Forstner
feat: Don't truncate error messages (#15818)
147989b
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
onurtemizkan pushed a commit
that referenced
this pull request
Apr 3, 2025
Luca Forstner@onurtemizkan
feat: Don't truncate error messages (#15818)
a6d2b06
Ref https://github.com/getsentry/projects/issues/837 for for not
truncating error messages and letting relay do that.
Kinda undoes #8593
Should be merged after
#15819 because
otherwise, we keep humongous strings in memory.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@kamilogorekkamilogorekAwaiting requested review from kamilogorek

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

maxValueLength is not applied for linked errors


2 participants

@Lms24@mydea