Uh oh!
There was an error while loading. Please reload this page.
feat(core): Introduce Sentry.startActiveSpan and Sentry.startSpan - #8803
Merged
Conversation
AbhiPrasad
requested review from
a team, kamilogorek and stephanie-anderson
and removed request for
a teamAugust 11, 2023 18:51
Contributor
size-limit report 📦
|
mydea
reviewed
Aug 14, 2023
| const parentSpan = scope.getSpan(); | ||
| function getActiveSpan(): Span | undefined { |
Member
There was a problem hiding this comment.
l: The naming is a bit confusing IMHO, as it appears as if this would just get the currently active span, but actually we create a new active span? What about e.g. createNewSpan or createChildSpan or something like this?
ContributorAuthor
There was a problem hiding this comment.
great point - renamed
mydea
reviewed
Aug 14, 2023
| let client: TestClient; | ||
| describe('trace', () => { | ||
| describe('startActiveSpan', () => { |
Member
There was a problem hiding this comment.
l: Should we keep the trace tests around? 🤔 not sure, maybe it's fine to remove them as well 🤷
ContributorAuthor
There was a problem hiding this comment.
I replaced the trace tests with startActiveSpan. I'll be removing trace afterwards considering it was an internal API.
mydea
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #8724
This PR introduces two new methods to the JavaScript SDK's public API.
Sentry.startActiveSpanandSentry.startSpan, detailed in the RFC about the new performance API.Sentry.startActiveSpanautomatically wraps a callback with a span and makes that span the active span for the execution context of the callback. The callback can be async or sync, and can return arbitrary values.Sentry.startSpanjust creates a span, but does not wrap it in a callback. It needs to be explicitly set on the scope just likeSentry.startTransaction.Under the hood these methods will create a transaction or span depending on if there is already an active span on the scope.