Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/serverless/src/awslambda.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import { performance } from 'perf_hooks';
import { types } from 'util';

import { AWSServices } from './awsservices';
import { serverlessEventProcessor } from './utils';
import { markEventUnhandled, serverlessEventProcessor } from './utils';

export * from '@sentry/node';

Expand DownExpand Up@@ -312,11 +312,11 @@ export function wrapHandler<TEvent, TResult>(
if (options.captureAllSettledReasons && Array.isArray(rv) && isPromiseAllSettledResult(rv)) {
const reasons = getRejectedReasons(rv);
reasons.forEach(exception => {
captureException(exception);
captureException(exception, scope => markEventUnhandled(scope));
});
}
} catch (e) {
captureException(e);
captureException(e, scope => markEventUnhandled(scope));
throw e;
} finally {
clearTimeout(timeoutWarningTimer);
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/cloud_events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { CloudEventFunction, CloudEventFunctionWithCallback, WrapperOptions } from './general';

export type CloudEventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -50,7 +50,7 @@ function _wrapCloudEventFunction(

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -68,13 +68,13 @@ function _wrapCloudEventFunction(
try {
fnResult = (fn as CloudEventFunctionWithCallback)(context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless/src/gcpfunction/events.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isThenable, logger } from '@sentry/utils';

import { domainify, proxyFunction } from '../utils';
import { domainify, markEventUnhandled, proxyFunction } from '../utils';
import type { EventFunction, EventFunctionWithCallback, WrapperOptions } from './general';

export type EventFunctionWrapperOptions = WrapperOptions;
Expand DownExpand Up@@ -52,7 +52,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>

const newCallback = domainify((...args: unknown[]) => {
if (args[0] !== null && args[0] !== undefined) {
captureException(args[0]);
captureException(args[0], scope => markEventUnhandled(scope));
}
transaction?.finish();

Expand All@@ -72,13 +72,13 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
try {
fnResult = (fn as EventFunctionWithCallback)(data, context, newCallback);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/serverless/src/gcpfunction/http.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import type { AddRequestDataToEventOptions } from '@sentry/node';
import { captureException, flush, getCurrentHub } from '@sentry/node';
import { isString, isThenable, logger, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';

import { domainify, proxyFunction } from './../utils';
import { domainify, markEventUnhandled, proxyFunction } from './../utils';
import type { HttpFunction, WrapperOptions } from './general';

// TODO (v8 / #5257): Remove this whole old/new business and just use the new stuff
Expand DownExpand Up@@ -122,13 +122,13 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
try {
fnResult = fn(req, res);
} catch (err) {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
}

if (isThenable(fnResult)) {
fnResult.then(null, err => {
captureException(err);
captureException(err, scope => markEventUnhandled(scope));
throw err;
});
}
Expand Down
13 changes: 13 additions & 0 deletions packages/serverless/src/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { runWithAsyncContext } from '@sentry/core';
import type { Event } from '@sentry/node';
import type { Scope } from '@sentry/types';
import { addExceptionMechanism } from '@sentry/utils';

/**
Expand DownExpand Up@@ -55,3 +56,15 @@ export function proxyFunction<A extends any[], R, F extends (...args: A) => R>(

return new Proxy(source, handler);
}

/**
* Marks an event as unhandled by adding a span processor to the passed scope.
*/
export function markEventUnhandled(scope: Scope): Scope {
scope.addEventProcessor(event => {
addExceptionMechanism(event, { handled: false });
return event;
});

return scope;
}
41 changes: 35 additions & 6 deletions packages/serverless/test/awslambda.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// NOTE: I have no idea how to fix this right now, and don't want to waste more time, as it builds just fine — Kamil
// eslint-disable-next-line import/no-unresolved
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
// eslint-disable-next-line import/no-unresolved
import type { Callback, Handler } from 'aws-lambda';

Expand DownExpand Up@@ -175,8 +176,8 @@ describe('AWSLambda', () => {
]);
const wrappedHandler = wrapHandler(handler, { flushTimeout: 1337, captureAllSettledReasons: true });
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2);
expect(SentryNode.captureException).toHaveBeenNthCalledWith(1, error, expect.any(Function));
expect(SentryNode.captureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
expect(SentryNode.captureException).toBeCalledTimes(2);
});
});
Expand DownExpand Up@@ -229,7 +230,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalledWith(2000);
Expand DownExpand Up@@ -308,7 +309,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(e);
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -375,7 +376,7 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -457,14 +458,42 @@ describe('AWSLambda', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
expectScopeSettings(fakeTransactionContext);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
}
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(3);

const error = new Error('wat');
const handler: Handler = async (_event, _context, _callback) => {
throw error;
};
const wrappedHandler = wrapHandler(handler);

try {
await wrappedHandler(fakeEvent, fakeContext, fakeCallback);
} catch (e) {
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
}
});

describe('init()', () => {
test('calls Sentry.init with correct sdk info metadata', () => {
Sentry.AWSLambda.init({});
Expand Down
44 changes: 35 additions & 9 deletions packages/serverless/test/gcpfunction.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import * as SentryNode from '@sentry/node';
import type { Event } from '@sentry/types';
import * as domain from 'domain';

import * as Sentry from '../src';
Expand All@@ -12,7 +13,6 @@ import type {
Request,
Response,
} from '../src/gcpfunction/general';

/**
* Why @ts-ignore some Sentry.X calls
*
Expand DownExpand Up@@ -198,7 +198,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -317,7 +317,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -382,7 +382,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -440,7 +440,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -469,7 +469,33 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

test('marks the captured error as unhandled', async () => {
expect.assertions(4);

const error = new Error('wat');
const handler: EventFunctionWithCallback = (_data, _context, _cb) => {
throw error;
};
const wrappedHandler = wrapEventFunction(handler);
await expect(handleEvent(wrappedHandler)).rejects.toThrowError(error);

expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));

// @ts-ignore just mocking around...
const scopeFunction = SentryNode.captureException.mock.calls[0][1];
const event: Event = { exception: { values: [{}] } };
let evtProcessor: ((e: Event) => Event) | undefined = undefined;
scopeFunction({ addEventProcessor: jest.fn().mockImplementation(proc => (evtProcessor = proc)) });

expect(evtProcessor).toBeInstanceOf(Function);
// @ts-ignore just mocking around...
expect(evtProcessor(event).exception.values[0].mechanism).toEqual({
handled: false,
type: 'generic',
});
});

Expand DownExpand Up@@ -537,7 +563,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -595,7 +621,7 @@ describe('GCPFunction', () => {
expect(SentryNode.fakeHub.startTransaction).toBeCalledWith(fakeTransactionContext);
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);
expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeTransaction.finish).toBeCalled();
expect(SentryNode.flush).toBeCalled();
Expand DownExpand Up@@ -625,7 +651,7 @@ describe('GCPFunction', () => {
// @ts-ignore see "Why @ts-ignore" note
expect(SentryNode.fakeScope.setSpan).toBeCalledWith(fakeTransaction);

expect(SentryNode.captureException).toBeCalledWith(error);
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
});
});

Expand Down