Uh oh!
There was an error while loading. Please reload this page.
feat(core): Add ServerRuntimeClient - #8930
Merged
AbhiPrasad merged 6 commits intoSep 5, 2023
Merged
Conversation
timfish
marked this pull request as draft
September 1, 2023 13:06
timfish
marked this pull request as ready for review
September 1, 2023 15:27
This was referenced Sep 1, 2023
mydea
reviewed
Sep 4, 2023
| if (isPlainObject(exception)) { | ||
| // This will allow us to group events based on top-level keys | ||
| // which is much better than creating new group when any key/value change | ||
| const message = `Non-Error exception captured with keys: ${extractExceptionKeysForMessage(exception)}`; |
Member
There was a problem hiding this comment.
l: I wonder if we want to align this with the changes we did for browser-based non-error-object capturing: #8374
But maybe we do that in a separate follow-up PR!
CollaboratorAuthor
There was a problem hiding this comment.
There has been some discussion around consolidating the node/browser eventbuilders too...
Contributor
There was a problem hiding this comment.
let's do this in a follow up PR after we merge in node sdk changes re: server runtime!
AbhiPrasad
approved these changes
Sep 5, 2023
| if (isPlainObject(exception)) { | ||
| // This will allow us to group events based on top-level keys | ||
| // which is much better than creating new group when any key/value change | ||
| const message = `Non-Error exception captured with keys: ${extractExceptionKeysForMessage(exception)}`; |
Contributor
There was a problem hiding this comment.
let's do this in a follow up PR after we merge in node sdk changes re: server runtime!
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #8693
The
ServerRuntimeClientis a near identical copy of the nextjsEdgeClient. To make it a direct replacement it has constructor options to override the eventplatform,runtime, andserver_name.This PR makes yet another copy of the Node
eventbuilder.tsbut after future PRs to remove theEdgeClientand makeNodeClientextendServerRuntimeClient, this will be the only copy. I've put theeventbuildercode in utils since some of these functions are used elsewhere outside of the clients and I don't want to export these from core and them become part of our public API. This is especially important since the browser SDK already exports it's own slightly differentexceptionFromError.