Uh oh!
There was an error while loading. Please reload this page.
ref(core): Introduce protected _getBreadcrumbs() on scope - #8961
Conversation
size-limit report 📦
|
lforst
left a comment
There was a problem hiding this comment.
Since this is public API and removing it (even when in the process of doing a major) is usually a lot of pain (in regards to documentation - migration guides etc), would you care to elaborate why we need this?
mydea
commented
Sep 7, 2023
yeah, sure, sorry, could have def. elaborated more on this. For POTEL I want to (experimentally) overwrite this to have a different logic to get the breadcrumbs for a scope. I figured it would be the cleanest solution to expose this as a function (similar to others we already have like this on the scope, like |
Making it easier to potentially change this e.g. for POTEL.
e8ed426 to
a68bf32Compare
Lms24
left a comment
There was a problem hiding this comment.
LGTM
If we do not like this being public API I could also make it a protected function, which should be good enough to be able to overwrite it in a subclass
No strong feeling but if it's not too much work then, let's do this. We can still make it public later on but reversing things is harder.
mydea
commented
Sep 7, 2023
Updated this to |
getBreadcrumbs() on scope to abstract this away_getBreadcrumbs() on scopeMaking it easier to potentially change this e.g. for POTEL.
Making it easier to potentially change this e.g. for POTEL.
Making it easier to potentially change this e.g. for POTEL.