ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ref: Remove all usages of ts-ignore#8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 7 commits into from
Sep 8, 2023
Merged

ref: Remove all usages of ts-ignore #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87a2f63
ref: Remove all usages of ts-ignore
AbhiPrasad Sep 7, 2023
701e670
remove unneeded ts-expect-error
AbhiPrasad Sep 7, 2023
0f4c61d
remove all unused directives
AbhiPrasad Sep 7, 2023
34fca77
fix in nextjs test
AbhiPrasad Sep 7, 2023
c6cbefd
remove some more ts-ignore cases
AbhiPrasad Sep 7, 2023
48dede3
switch nextjs to tsignore
AbhiPrasad Sep 8, 2023
e239161
remove usage of ts-expect-error in test
AbhiPrasad Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/test/errorhandler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -532,7 +532,7 @@ describe('SentryErrorHandler', () => {
}),
};

// @ts-ignore this is a minmal hub, we're missing a few props but that's ok
// @ts-expect-error this is a minmal hub, we're missing a few props but that's ok
jest.spyOn(SentryBrowser, 'getCurrentHub').mockImplementationOnce(() => {
return { getClient: () => client };
});
Expand Down
4 changes: 2 additions & 2 deletions packages/browser-integration-tests/suites/replay/bufferMode/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand DownExpand Up@@ -210,7 +210,7 @@ sentryTest(
expect(
await page.evaluate(() => {
const replayIntegration = (window as unknown as Window & { Replay: InstanceType<typeof Replay> }).Replay;
// @ts-ignore private
// @ts-expect-error private
const replay = replayIntegration._replay;
replayIntegration.startBuffering();
return replay.isEnabled();
Expand Down
10 changes: 5 additions & 5 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -120,7 +120,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br
method: 'POST',
body: body,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -359,7 +359,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get
method: 'POST',
body: 'input body',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...egration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, p
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -117,7 +117,7 @@ sentryTest('captures request headers as POJO', async ({ getLocalTestPath, page,
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -201,7 +201,7 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag
});
/* eslint-disable */
fetch(request).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -284,7 +284,7 @@ sentryTest('captures request headers as Headers instance', async ({ getLocalTest
method: 'POST',
headers,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -367,7 +367,7 @@ sentryTest('does not captures request headers if URL does not match', async ({ g
'X-Test-Header': 'test-value',
},
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
4 changes: 2 additions & 2 deletions ...integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest
method: 'POST',
body: '{"foo":"bar"}',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -125,7 +125,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal
method: 'POST',
body: blob,
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
8 changes: 4 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -122,7 +122,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -203,7 +203,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -282,7 +282,7 @@ sentryTest('does not capture response body when URL does not match', async ({ ge
fetch('http://localhost:7654/bar', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...gration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -113,7 +113,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -194,7 +194,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/bar').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -131,7 +131,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
await page.evaluate(() => {
/* eslint-disable */
fetch('http://localhost:7654/foo').then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand DownExpand Up@@ -218,7 +218,7 @@ sentryTest('captures response size from non-text response body', async ({ getLoc
fetch('http://localhost:7654/foo', {
method: 'POST',
}).then(() => {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
Sentry.captureException('test error');
});
/* eslint-enable */
Expand Down
10 changes: 5 additions & 5 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures text request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -124,7 +124,7 @@ sentryTest('captures JSON request body', async ({ getLocalTestPath, page, browse

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -209,7 +209,7 @@ sentryTest('captures non-text request body', async ({ getLocalTestPath, page, br

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -290,7 +290,7 @@ sentryTest('captures text request body when matching relative URL', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -371,7 +371,7 @@ sentryTest('does not capture request body when URL does not match', async ({ get

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -135,7 +135,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...r-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,7 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -134,7 +134,7 @@ sentryTest('captures request size from non-text request body', async ({ getLocal

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
8 changes: 4 additions & 4 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseBody/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ sentryTest('captures text response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -132,7 +132,7 @@ sentryTest('captures JSON response body', async ({ getLocalTestPath, page, brows

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -217,7 +217,7 @@ sentryTest('captures non-text response body', async ({ getLocalTestPath, page, b

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -304,7 +304,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
4 changes: 2 additions & 2 deletions ...tegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseHeaders/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page, browser

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -141,7 +141,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
6 changes: 3 additions & 3 deletions ...-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ sentryTest(

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -144,7 +144,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand DownExpand Up@@ -237,7 +237,7 @@ sentryTest('captures response size for non-string bodies', async ({ getLocalTest

xhr.addEventListener('readystatechange', function () {
if (xhr.readyState === 4) {
// @ts-ignore Sentry is a global
// @ts-expect-error Sentry is a global
setTimeout(() => Sentry.captureException('test error', 0));
}
});
Expand Down
Loading