Skip to content

Document how X-Sentry-Token re: source maps - #901

Merged
benvinegar merged 2 commits into
masterfrom
source-map-secret
Mar 23, 2017
Merged

Document how X-Sentry-Token re: source maps#901
benvinegar merged 2 commits into
masterfrom
source-map-secret

Conversation

@benvinegar

Copy link
Copy Markdown
Contributor

@benvinegarbenvinegar mentioned this pull request Mar 23, 2017
@benvinegar

Copy link
Copy Markdown
ContributorAuthor

cc @mattrobenolt – does what @graingert and I've written make sense?

@mattrobenolt

Copy link
Copy Markdown
Contributor

It may be worth mentioning that they can also set their own header entirely. For example, basic auth could be leveraged here if they set the header to Authorization and set the key to Basic .....

@benvinegar

benvinegar commented Mar 23, 2017

Copy link
Copy Markdown
ContributorAuthor

For example, basic auth could be leveraged here if they set the header to Authorization and set the key to Basic .....

I don't think we ever merged the Sentry PR that lets you do that (which might also be a @graingert joint).

@mattrobenolt

Copy link
Copy Markdown
Contributor

Yeah, he threw up the original PR, and I carried it through with getsentry/sentry#4630

It made it into 8.13 release.

@benvinegar

Copy link
Copy Markdown
ContributorAuthor

@mattrobenolt – ah, I see, I misread settings.

I made an update. That work?

@benvinegar
benvinegar merged commit 069e7d0 into masterMar 23, 2017
@benvinegar
benvinegar deleted the source-map-secret branch March 23, 2017 06:11
@graingert

graingert commented Mar 23, 2017 via email

Copy link
Copy Markdown
Contributor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@benvinegar@mattrobenolt@graingert