Uh oh!
There was an error while loading. Please reload this page.
Document how X-Sentry-Token re: source maps - #901
Merged
Conversation
Closed
benvinegar
commented
Mar 23, 2017
ContributorAuthor
cc @mattrobenolt – does what @graingert and I've written make sense? |
mattrobenolt
commented
Mar 23, 2017
Contributor
It may be worth mentioning that they can also set their own header entirely. For example, basic auth could be leveraged here if they set the header to |
ContributorAuthor
I don't think we ever merged the Sentry PR that lets you do that (which might also be a @graingert joint). |
mattrobenolt
commented
Mar 23, 2017
Contributor
Yeah, he threw up the original PR, and I carried it through with getsentry/sentry#4630 It made it into 8.13 release. |
benvinegar
commented
Mar 23, 2017
ContributorAuthor
@mattrobenolt – ah, I see, I misread settings. I made an update. That work? |
graingert
commented
Mar 23, 2017
via email
Contributor
Yep it works (I'm using it) …On 23 Mar 2017 06:11, "Ben Vinegar" ***@***.***> wrote:
Merged #901 <#901>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#901 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZQTNblo9CLDFnKLccklm2a5aXSYpCWks5rog0lgaJpZM4MmMDo>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #705
cc @graingert