feat(vue): Expose `VueIntegration` to initialize vue app later by mydea · Pull Request #9180 · getsentry/sentry-javascript

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea · 2023-10-05T13:27:14Z

This exposes a new VueIntegration from @sentry/vue which can be used to initialize vue error tracking for a late-defined vue app.

With this, you can initialize the SDK early, even if vue is not setup yet:

import*asSentryfrom'@sentry/vue';Sentry.init({dsn: '...',// Filter out default `Vue` integrationintegrations: (integration)=>integration.id!=='Vue',});// Sometimes laterconstapp=createApp({template: '<div>hello</div>',});Sentry.addIntegration(newSentry.VueIntegration({ app }));

AbhiPrasad

We'll need to add docs for this too!

AbhiPrasad · 2023-10-05T13:29:19Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue): void {


I wonder if we should pass in client as an optional arg.

sure, why not! will adjust it

I added an optional client argument to be passed.

Lms24

This might come in very handy for the Astro SDK! looks good to me but I had a suggestion around the API. As I said, we can probably expand it further with another optional param.

Lms24 · 2023-10-05T13:54:13Z

+/**
+ * Initialize Vue-specific error monitoring for a given Vue app.
+ */
+export function initVueApp(app: Vue, client?: BrowserClient): void {


I'm just wondering (we can add this later if we actually need it) but wdyt about optionally passing in the Vue-specific options that are used by vueInit? I'm thinking about a case where users would initialize the Browser SDK (or that would be done for them e.g. in the Astro SDK) and they'd additionally pass in the Vue options here.

Hmm maybe actually instead of passing the client optionally, we should pass the options directly? 🤔 as we don't really need the client in there, we just pick the options off...?

mydea · 2023-10-05T15:17:33Z

After talking about this with Lukas, I rewrote this to actually expose this as an integration. This is more in line with how we do this in other places. With this, you can lazy initialize this like this:

Sentry.init({integrations: (integration)=>integration.id!=='Vue',});// LaterSentry.getCurrentHub().getClient()?.addIntegration(newSentry.VueIntegration({ app }));

Plus we also talked about the need to have a proper top level method to add an integration, (which we can do in a separate PR), it should just be:

Sentry.addIntegration(...);

in an ideal world.

This also makes it easier to actually use @sentry/vue and @sentry/browser together, in case this is necessary, as you can really also add the vue integration to a regular browser client etc.

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

mydea requested review from AbhiPrasad and Lms24 October 5, 2023 13:27

mydea self-assigned this Oct 5, 2023

AbhiPrasad approved these changes Oct 5, 2023
View reviewed changes

feat(vue): Expose initVueApp method to initialize vue app later
b037465

mydea force-pushed the fn/initVueApp branch from c8fcfe8 to b037465Compare October 5, 2023 13:48

Lms24 approved these changes Oct 5, 2023
View reviewed changes

Lms24 mentioned this pull request Oct 5, 2023
Sentry Astro SDK #9182
Closed

ref: Refactor to integration
827475d

mydea changed the title ~~feat(vue): Expose initVueApp method to initialize vue app later~~feat(vue): Expose VueIntegration to initialize vue app laterOct 5, 2023

Lms24 approved these changes Oct 6, 2023
View reviewed changes

mydea mentioned this pull request Oct 6, 2023
feat(core): Add addIntegration utility #9186
Merged

mydea merged commit 81b4b5e into developOct 9, 2023

mydea deleted the fn/initVueApp branch October 9, 2023 10:17

Uh oh!

Uh oh!

Conversation

mydea commented Oct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhiPrasad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

mydea commented Oct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhiPrasad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

mydea commented Oct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhiPrasad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

mydea commented Oct 5, 2023•
edited
Loading

mydea commented Oct 5, 2023•
edited
Loading

mydea commented Oct 5, 2023•
edited
Loading

mydea commented Oct 5, 2023•
edited
Loading