Skip to content

feat: Deno SDK - #9206

Merged
lforst merged 23 commits into
getsentry:developfrom
timfish:feat/deno
Oct 12, 2023
Merged

feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom
timfish:feat/deno

Conversation

@timfish

@timfishtimfish commented Oct 9, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#3009

This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.

There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:

Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.

Other points to note:

  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm

Tasks:

  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  • Script to Install Deno locally
  • Basic tests
  • deno.land publishing script
    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  • Readme

@timfish
timfish marked this pull request as ready for review October 10, 2023 19:56
@timfish
timfish requested a review from lforstOctober 10, 2023 20:03
lforst
lforst reviewed Oct 11, 2023
View reviewed changes

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3

Comment thread.github/workflows/build.yml Outdated
Comment thread.github/workflows/build.yml Outdated
Comment threadpackages/deno/lib.deno.d.ts Outdated
Comment threadpackages/deno/rollup.config.js Outdated
Comment threadpackages/deno/rollup.config.js Outdated
Comment threadpackages/deno/.eslintrc.js
{
files: ['./test/*.ts'],
rules: {
'import/no-unresolved': 'off',

@lforstlforstOct 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.

@timfishtimfishOct 11, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.
Some imports use denos URL imports which eslint doesn't understand

@lforstlforstOct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!

Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
const error = new Error();

addGlobalEventProcessor((event: Event): Event | null => {
const appRoot = getAppRoot(error);

@lforstlforstOct 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.

@timfishtimfishOct 11, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64

@lforstlforstOct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!

Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';

@lforstlforstOct 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.

@timfishtimfishOct 11, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!

@timfishtimfishOct 11, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.

For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.

I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.

@lforstlforstOct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.

@timfish

timfish commented Oct 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...

@lforst
lforst merged commit 5140e73 into getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Deno server

2 participants

@timfish@lforst
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat: Deno SDK by timfish · Pull Request #9206 · getsentry/sentry-javascript · GitHub
Skip to content
feat: Deno SDK - #9206
Merged
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Oct 12, 2023
Merged
feat: Deno SDK#9206
lforst merged 23 commits into
getsentry:developfrom 
timfish:feat/deno
Conversation
@timfish
@timfishtimfish
commented
Oct 9, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#3009
This creates a Deno SDK which bundles all code and dependencies into ./build/index.js along with bundled types at ./build/index.d.ts.
There is a console prompt on startup if you haven't granted permissions for net access to the Sentry host:
Sentry SDK requires 'net' permission to send events.
Run with '--allow-net=o447951.ingest.sentry.io' to grant the requires permissions.

It might be worth adding another prompt if we can't read the source files otherwise ContextLines won't be able to load anything.
Other points to note:
  • The integrations mostly came from my previous deno work
  • We require @rollup/plugin-commonjs because lru_map is commonjs. Vendoring lru_map will simplify this
  • The new package is set as "private": true, since we don't want to publish this to npm
Tasks:
  • fetch instrumentation is not working
  • console instrumentation will not be working in modules loaded via npm:* specifiers
    • We can get the node global via import { GLOBAL_OBJ } from 'npm:@sentry/utils'
  •  Script to Install Deno locally
  •  Basic tests
  •  deno.land publishing script

    • We can't use the default deploy web-hook because our library is compiled and not stored compiled in the repo
  •  Readme
@timfish
timfish
marked this pull request as ready for review
October 10, 2023 19:56
@timfish
timfish
requested a review
from lforstOctober 10, 2023 20:03
lforst
lforst
reviewed
Oct 11, 2023
View reviewed changes
@lforstlforst
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first pass. It is quite a bit of feedback but don't let that distract from how awesome this is. Great job man! <3
Comment thread.github/workflows/build.yml
Outdated

Comment thread.github/workflows/build.yml
Outdated

Comment threadpackages/deno/lib.deno.d.ts
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/rollup.config.js
Outdated

Comment threadpackages/deno/.eslintrc.js
 {
 files: ['./test/*.ts'],
 rules: {
 'import/no-unresolved': 'off',
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get rid of all the npm: prefixes we can probably enable this rule again.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in /test/* is Deno typescript.

Some imports use denos URL imports which eslint doesn't understand
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out!
Comment threadpackages/deno/src/integrations/contextlines.ts
Comment threadpackages/deno/src/integrations/normalize.ts
 const error = new Error();

 addGlobalEventProcessor((event: Event): Event | null => {
 const appRoot = getAppRoot(error);
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: Can we put this in the surrounding scope? That way we don't have to do the work over and over again.
@timfishtimfishOct 11, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getAppRoot result is cached:
https://github.com/getsentry/sentry-javascript/pull/9206/files/ffb3f9e06405bf46b00a238a5ee95d96a5f8d8ac#diff-ee43ec0e415f8787379abe383d81b30c9a5e0e66c11ffe3eeb78a25a6fb3f521R55-R64
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I am blind. Sorry!
Comment threadpackages/deno/src/integrations/normalize.ts
Comment threadpackages/deno/test/mod.test.ts

import { defaultIntegrations, DenoClient, Hub, Scope } from '../build/index.js';
import { getNormalizedEvent } from './normalize.ts';
import { makeTestTransport } from './transport.ts';
@lforstlforstOct 11, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: We can configure the tsconfig to adjust the resolution of these imports to allow for .ts endings. Right now TS is screaming.
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I have the Deno vscode extension installed so don't see these errors!
@timfishtimfishOct 11, 2023

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowImportingTsExtensions is TypeScript 5+ and we're on 4.9.5.
For now I've added the Deno vscode extension to the recommended extensions and only enabled if for packages/deno/test.
I've also had to disable eslint for the ./scripts directory because the parser can't deal with top level await.
@lforstlforstOct 12, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok this also makes sense. I briefly discussed in the team whether we should bump the repo TS version to 5 but there are some considerations with regards to how we build types. Let's stick with the extension for now! Thanks for experimenting here.
@timfish
timfish
commented
Oct 12, 2023

Copy link


Copy Markdown

CollaboratorAuthor
The main thing I've learnt is that at least for TypeScript < v5, it's impossible to create a tsconfig that gives zero errors for valid Deno TypeScript code...
@lforst
lforst
merged commit 5140e73
into
getsentry:developOct 12, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support for Deno server


2 participants

@timfish@lforst