ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ref(replay): Use rrweb for slow click detection - #9408

Merged
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay
Nov 2, 2023
Merged

ref(replay): Use rrweb for slow click detection#9408
mydea merged 2 commits into
developfrom
fn/rage-click-use-replay

Conversation

@mydea

Copy link
Copy Markdown
Member

This refactors the slow/rage click detection to use rrweb events instead of adding our own event listeners.

  • We look for incremental snapshot events, and update the _lastMutation and _lastScroll properties based on them.
  • If a full snapshot happens, we interpret it as a mutation. this is not necessarily correct, but we don't know any different. also this shouldn't matter much because a full snapshot only happens in error mode, in which case things that happened before the full checkout should be discarded anyhow, so 🤷

Integration tests for this are still passing, so it seems to me to be a good change. Hopefully this:

  1. Decreases perf overhead by only using a single instrumentation instead of multiple overlapping ones
  2. Increases consistency by ensuring that whatever we see changing in the replay will also be considered the same way for slow/rage click detection.

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)70.94 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)56.15 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)30.97 KB (0%)
@sentry/browser - Webpack (gzipped)21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)67.33 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)215.21 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)71.28 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped)21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)87.75 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped)47.86 KB (0%)

@github-actions

github-actionsBot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 250e67c70.45 ms79.46 ms+9.01 ms+12.78 %64.61 ms-5.84 ms-8.29 %
Baseline 4babd0249.64 ms52.92 ms+3.28 ms+6.60 %56.13 ms+6.49 ms+13.06 %
CLSThis PR 250e67c0.25 ms0.25 ms-0.00 ms-0.53 %0.25 ms+0.00 ms+0.10 %
Baseline 4babd020.26 ms0.23 ms-0.02 ms-8.40 %0.26 ms+0.00 ms+1.21 %
CPUThis PR 250e67c20.37 %22.96 %+2.58 pp+12.69 %46.63 %+26.26 pp+128.88 %
Baseline 4babd0215.10 %17.01 %+1.91 pp+12.68 %37.70 %+22.60 pp+149.73 %
JS heap avgThis PR 250e67c3.87 MB6.57 MB+2.69 MB+69.61 %7.2 MB+3.33 MB+85.98 %
Baseline 4babd023.91 MB7.31 MB+3.4 MB+87.03 %7.16 MB+3.26 MB+83.34 %
JS heap maxThis PR 250e67c5.01 MB8.48 MB+3.47 MB+69.24 %13.91 MB+8.9 MB+177.60 %
Baseline 4babd024.94 MB8.72 MB+3.78 MB+76.44 %14.36 MB+9.42 MB+190.54 %
netTxThis PR 250e67c0 B321.66 kB+321.66 kBn/a37.78 kB+37.78 kBn/a
Baseline 4babd020 B360.59 kB+360.59 kBn/a100.41 kB+100.41 kBn/a
netRxThis PR 250e67c0 B41 B+41 Bn/a41 B+41 Bn/a
Baseline 4babd020 B41 B+41 Bn/a41 B+41 Bn/a
netCountThis PR 250e67c01+1n/a1+1n/a
Baseline 4babd0201+1n/a1+1n/a
netTimeThis PR 250e67c0.00 ms163.55 ms+163.55 msn/a125.16 ms+125.16 msn/a
Baseline 4babd020.00 ms71.18 ms+71.18 msn/a37.35 ms+37.35 msn/a

Baseline results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

Previous results on branch: fn/rage-click-use-replay

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
4babd02+6.49 ms+0.00 ms+22.60 pp+3.26 MB+9.42 MB+100.41 kB+41 B+1+37.35 ms
b2a56bc-10.32 ms+0.00 ms+23.11 pp+3.32 MB+9.19 MB+30.07 kB+41 B+1+121.95 ms
2ec3582+5.99 ms+0.01 ms+21.29 pp+3.36 MB+7.93 MB+49.55 kB+41 B+1+110.53 ms
a8cf899-20.39 ms+0.01 ms+24.21 pp+3.36 MB+7.47 MB+104.09 kB+41 B+1+106.98 ms
4371b2c-19.42 ms+0.01 ms+27.63 pp+3.51 MB+7.49 MB+104.28 kB+82 B+2+155.48 ms
4fc18b9-6.40 ms-0.00 ms+27.01 pp+3.37 MB+7.5 MB+104.19 kB+66 B+1.6+119.34 ms
a5e8424-0.27 ms+0.02 ms+25.67 pp+3.34 MB+8.17 MB+49.6 kB+41 B+1+95.57 ms
700d280+3.74 ms+0.02 ms+26.36 pp+3.4 MB+7.85 MB+10.52 kB+41 B+1+66.55 ms
700d280-10.82 ms-0.01 ms+29.34 pp+3.57 MB+7.56 MB+103.92 kB+82 B+2+201.17 ms
2685b0c-22.18 ms-0.01 ms+28.66 pp+3.54 MB+7.38 MB+104.19 kB+82 B+2+176.40 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 02 Nov 2023 12:28:28 GMT

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we decided to implement using separate listeners in case we wanted to promote this detection to the core SDK. We've seen that these issues can be a bit noisy, so we're keeping them Replay specific.

/** Update the click detector based on a recording event of rrweb. */
export function updateClickDetectorForRecordingEvent(clickDetector: ReplayClickDetector, event: RecordingEvent): void {
try {
// We interpret a full snapshot as a mutation (this may not be true, but there is no way for us to know)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine - we've thought about doing a full snapshot at a timed interval so lessen the effects of a corrupted segment. Though we haven't done anything with that idea.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this, maybe we should just ignore full snapshots.
There is a small possibility that this leads to a false positive (e.g. a click leads to a change that is only reflected in the full snapshot, but not in any incremental snapshot). But probably in reality the chances of this are pretty slim 🤔

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg so I changed this to ignore full snapshots, and also added integration tests for these scenarios:

  1. a click triggers an error and no mutation - slow click is captured ✔️
  2. a click triggers an error and a mutation - slow click is not captured ✔️

@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 281ba15 to b311d7eCompareOctober 31, 2023 08:31
@mydea
mydea requested a review from billyvgOctober 31, 2023 08:31
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch 2 times, most recently from 2509ad1 to 80153baCompareOctober 31, 2023 12:51
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 80153ba to 79fd745CompareOctober 31, 2023 15:14
@mydea
mydeaforce-pushed the fn/rage-click-use-replay branch from 79fd745 to 1e2b0b2CompareNovember 2, 2023 12:14
@mydea
mydea merged commit d8beaa0 into developNov 2, 2023
@mydea
mydea deleted the fn/rage-click-use-replay branch November 2, 2023 13:11
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/tracing from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/tracing</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/tracing
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJhMDNmMTYzYi04NzI1LTQ3ZGUtODQ3Yy1iMWU4YzdjMGYwODkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImEwM2YxNjNiLTg3MjUtNDdkZS04NDdjLWIxZThjN2MwZjA4OSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/tracing&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"a03f163b-8725-47de-847c-b1e8c7c0f089","prPublicId":"a03f163b-8725-47de-847c-b1e8c7c0f089","dependencies":[{"name":"@sentry/tracing","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:34:00.370Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@sentry/browser from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMTg1YmNlNC00NzhlLTQzN2YtOWEyZC0zNDRhNDU4YTk4MzIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMxODViY2U0LTQ3OGUtNDM3Zi05YTJkLTM0NGE0NThhOTgzMiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"3185bce4-478e-437f-9a2d-344a458a9832","prPublicId":"3185bce4-478e-437f-9a2d-344a458a9832","dependencies":[{"name":"@sentry/browser","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:32:57.066Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
ccomb added a commit to MTES-MCT/ecobalyse that referenced this pull request Nov 30, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade @sentry/node
from 7.77.0 to 7.78.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-11-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/node</b></summary>
<ul>
<li>
<b>7.78.0</b> - <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases/tag/7.78.0">2023-11-08</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Replay Bundle Size improvements</strong></li>
</ul>
<p>We've dramatically decreased the bundle size of our Replay package,
reducing the minified &amp; gzipped bundle size by ~20 KB!<br>
This was possible by extensive use of tree shaking and a host of small
changes to reduce our footprint:</p>
<ul>
<li>feat(replay): Update rrweb to 2.2.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1969840261" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9414"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9414/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9414">#9414</a>)</li>
<li>ref(replay): Use fflate instead of pako for compression (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1973888368" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9436"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9436/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9436">#9436</a>)</li>
</ul>
<p>By using <a
href="https://docs.sentry.io/platforms/javascript/configuration/tree-shaking/"
rel="nofollow">tree shaking</a> it is possible to shave off up to 10
additional KB of the bundle.</p>
<h4>Other Changes</h4>
<ul>
<li>feat(astro): Add Sentry middleware (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1975970592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9445"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9445/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9445">#9445</a>)</li>
<li>feat(feedback): Add "outline focus" and "foreground hover" vars (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980194755" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9462"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9462/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9462">#9462</a>)</li>
<li>feat(feedback): Add <code>openDialog</code> and
<code>closeDialog</code> onto integration interface (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980365149" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9464"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9464/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9464">#9464</a>)</li>
<li>feat(feedback): Implement new user feedback embeddable widget (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1935671114" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9217"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9217/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9217">#9217</a>)</li>
<li>feat(nextjs): Add automatic sourcemapping for edge part of the SDK
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1978949258" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9454"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9454/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9454">#9454</a>)</li>
<li>feat(nextjs): Add client routing instrumentation for app router (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1975986800" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9446"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9446/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9446">#9446</a>)</li>
<li>feat(node-experimental): Add hapi tracing support (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1976171644" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9449"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9449/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9449">#9449</a>)</li>
<li>feat(replay): Allow to configure <code>beforeErrorSampling</code>
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1981293109" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9470"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9470/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9470">#9470</a>)</li>
<li>feat(replay): Stop fixing truncated JSONs in SDK (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1974067491" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9437/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9437">#9437</a>)</li>
<li>fix(nextjs): Fix sourcemaps resolving for local dev when basePath is
set (<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1979432990" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9457/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9457">#9457</a>)</li>
<li>fix(nextjs): Only inject basepath in dev mode (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1980792362" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9465"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9465/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9465">#9465</a>)</li>
<li>fix(replay): Ensure we stop for rate limit headers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1970781544" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9420"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9420/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9420">#9420</a>)</li>
<li>ref(feedback): Add treeshaking for logger statements (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1981622966" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9475/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9475">#9475</a>)</li>
<li>ref(replay): Use rrweb for slow click detection (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1967891591" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9408"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9408/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9408">#9408</a>)</li>
<li>build(polyfills): Remove output format specific logic (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1980848552" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#9467"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/9467/hovercard"
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/pull/9467">#9467</a>)</li>
</ul>
<h2>Bundle size 📦</h2>
<table>
<thead>
<tr>
<th>Path</th>
<th>Size</th>
</tr>
</thead>
<tbody>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.24 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking
flags (gzipped)</td>
<td>55.48 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - Webpack (gzipped)</td>
<td>30.97 KB</td>
</tr>
<tr>
<td>@ sentry/browser - Webpack (gzipped)</td>
<td>21.29 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle
(gzipped)</td>
<td>61.82 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)</td>
<td>29.09 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (gzipped)</td>
<td>21.23 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified
&amp; uncompressed)</td>
<td>194.87 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified &amp;
uncompressed)</td>
<td>88.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser - ES6 CDN Bundle (minified &amp; uncompressed)</td>
<td>63.28 KB</td>
</tr>
<tr>
<td>@ sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)</td>
<td>31.8 KB</td>
</tr>
<tr>
<td>@ sentry/react (incl. Tracing, Replay) - Webpack (gzipped)</td>
<td>65.61 KB</td>
</tr>
<tr>
<td>@ sentry/react - Webpack (gzipped)</td>
<td>21.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client (incl. Tracing, Replay) - Webpack
(gzipped)</td>
<td>82.34 KB</td>
</tr>
<tr>
<td>@ sentry/nextjs Client - Webpack (gzipped)</td>
<td>48.12 KB</td>
</tr>
<tr>
<td>@ sentry-internal/feedback - Webpack (gzipped)</td>
<td>15.81 KB</td>
</tr>
</tbody>
</table>
</li>
<li>
<b>7.77.0</b> - 2023-10-31
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/getsentry/sentry-javascript/releases">@sentry/node
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIwMzZiODVlMy0yYTA4LTQ4NTgtOTczNy0wOTQ5ZTRjMjU5ZmMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjAzNmI4NWUzLTJhMDgtNDg1OC05NzM3LTA5NDllNGMyNTlmYyJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/node&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"036b85e3-2a08-4858-9737-0949e4c259fc","prPublicId":"036b85e3-2a08-4858-9737-0949e4c259fc","dependencies":[{"name":"@sentry/node","from":"7.77.0","to":"7.78.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-11-08T10:33:00.392Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christophe Combelles <ccomb@free.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@billyvg