Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/astro/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ Install the Sentry Astro SDK with the `astro` CLI:
npx astro add @sentry/astro
```

Complete the setup by adding your DSN and source maps upload configuration:
Add your DSN and source maps upload configuration:

```javascript
import { defineConfig } from "astro/config";
Expand All@@ -56,6 +56,22 @@ Follow [this guide](https://docs.sentry.io/product/accounts/auth-tokens/#organiz
SENTRY_AUTH_TOKEN="your-token"
```

Complete the setup by adding the Sentry middleware to your `src/middleware.js` file:

```javascript
// src/middleware.js
import { sequence } from "astro:middleware";
import * as Sentry from "@sentry/astro";

export const onRequest = sequence(
Sentry.sentryMiddleware(),
// Add your other handlers after sentryMiddleware
);
```

This middleware creates server-side spans to monitor performance on the server for page load and endpoint requests.


## Configuration

Check out our docs for configuring your SDK setup:
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/index.server.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,5 +62,6 @@ export {
export * from '@sentry/node';

export { init } from './server/sdk';
export { handleRequest } from './server/middleware';

export default sentryAstro;
123 changes: 123 additions & 0 deletions packages/astro/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
import { captureException, configureScope, startSpan } from '@sentry/node';
import { addExceptionMechanism, objectify, stripUrlQueryAndFragment, tracingContextFromHeaders } from '@sentry/utils';
import type { APIContext, MiddlewareResponseHandler } from 'astro';

type MiddlewareOptions = {
/**
* If true, the client IP will be attached to the event by calling `setUser`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* This will only work if your app is configured for SSR
*
* @default false (recommended)
*/
trackClientIp?: boolean;

/**
* If true, the headers from the request will be attached to the event by calling `setExtra`.
* Only set this to `true` if you're fine with collecting potentially personally identifiable information (PII).
*
* @default false (recommended)
*/
trackHeaders?: boolean;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

captureException(objectifiedErr, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
type: 'astro',
handled: false,
data: {
function: 'astroMiddleware',
},
});
return event;
});

return scope;
});

return objectifiedErr;
}

export const handleRequest: (options?: MiddlewareOptions) => MiddlewareResponseHandler = (
options = { trackClientIp: false, trackHeaders: false },
) => {
return async (ctx, next) => {
const method = ctx.request.method;
const headers = ctx.request.headers;

const { dynamicSamplingContext, traceparentData, propagationContext } = tracingContextFromHeaders(
headers.get('sentry-trace') || undefined,
headers.get('baggage'),
);

const allHeaders: Record<string, string> = {};
headers.forEach((value, key) => {
allHeaders[key] = value;
});

configureScope(scope => {
scope.setPropagationContext(propagationContext);

if (options.trackClientIp) {
scope.setUser({ ip_address: ctx.clientAddress });
}
});

try {
// storing res in a variable instead of directly returning is necessary to
// invoke the catch block if next() throws
const res = await startSpan(
{
name: `${method} ${interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params)}`,
op: `http.server.${method.toLowerCase()}`,
origin: 'auto.http.astro',
status: 'ok',
...traceparentData,
metadata: {
source: 'route',
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,
},
data: {
method,
url: stripUrlQueryAndFragment(ctx.url.href),
...(ctx.url.search && { 'http.query': ctx.url.search }),
...(ctx.url.hash && { 'http.fragment': ctx.url.hash }),
...(options.trackHeaders && { headers: allHeaders }),
},
},
async span => {
const res = await next();
if (span && res.status) {
span.setHttpStatus(res.status);
}
return res;
},
);
return res;
} catch (e) {
sendErrorToSentry(e);
throw e;
}
// TODO: flush if serveless (first extract function)
};
};

/**
* Interpolates the route from the URL and the passed params.
* Best we can do to get a route name instead of a raw URL.
*
* exported for testing
*/
export function interpolateRouteFromUrlAndParams(rawUrl: string, params: APIContext['params']): string {
return Object.entries(params).reduce((interpolateRoute, value) => {
const [paramId, paramValue] = value;
return interpolateRoute.replace(new RegExp(`(/|-)${paramValue}(/|-|$)`), `$1[${paramId}]$2`);
}, rawUrl);
}
210 changes: 210 additions & 0 deletions packages/astro/test/server/middleware.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,210 @@
import * as SentryNode from '@sentry/node';
import * as SentryUtils from '@sentry/utils';
import { vi } from 'vitest';

import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';

describe('sentryMiddleware', () => {
const startSpanSpy = vi.spyOn(SentryNode, 'startSpan');

afterEach(() => {
vi.clearAllMocks();
});

it('creates a span for an incoming request', async () => {
const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users/123/details',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/123/details'),
params: {
id: '123',
},
};
const nextResult = Promise.resolve({ status: 200 });
const next = vi.fn(() => nextResult);

// @ts-expect-error, a partial ctx object is fine here
const resultFromNext = middleware(ctx, next);

expect(startSpanSpy).toHaveBeenCalledWith(
{
data: {
method: 'GET',
url: 'https://mydomain.io/users/123/details',
},
metadata: {
source: 'route',
},
name: 'GET /users/[id]/details',
op: 'http.server.get',
origin: 'auto.http.astro',
status: 'ok',
},
expect.any(Function), // the `next` function
);

expect(next).toHaveBeenCalled();
expect(resultFromNext).toStrictEqual(nextResult);
});

it('throws and sends an error to sentry if `next()` throws', async () => {
const scope = {
addEventProcessor: vi.fn().mockImplementation(cb => cb({})),
};
// @ts-expect-error, just testing the callback, this is okay for this test
const captureExceptionSpy = vi.spyOn(SentryNode, 'captureException').mockImplementation((ex, cb) => cb(scope));
const addExMechanismSpy = vi.spyOn(SentryUtils, 'addExceptionMechanism');

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers(),
},
url: new URL('https://myDomain.io/users/'),
params: {},
};

const error = new Error('Something went wrong');

const next = vi.fn(() => {
throw error;
});

// @ts-expect-error, a partial ctx object is fine here
await expect(async () => middleware(ctx, next)).rejects.toThrowError();

expect(captureExceptionSpy).toHaveBeenCalledWith(error, expect.any(Function));
expect(scope.addEventProcessor).toHaveBeenCalledTimes(1);
expect(addExMechanismSpy).toHaveBeenCalledWith(
{}, // the mocked event
{
handled: false,
type: 'astro',
data: { function: 'astroMiddleware' },
},
);
});

it('attaches tracing headers', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest();
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'sentry-trace': '12345678901234567890123456789012-1234567890123456-1',
baggage: 'sentry-release=1.0.0',
}),
},
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setPropagationContext).toHaveBeenCalledWith({
dsc: {
release: '1.0.0',
},
parentSpanId: '1234567890123456',
sampled: true,
spanId: expect.any(String),
traceId: '12345678901234567890123456789012',
});

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
metadata: {
source: 'route',
dynamicSamplingContext: {
release: '1.0.0',
},
},
parentSampled: true,
parentSpanId: '1234567890123456',
traceId: '12345678901234567890123456789012',
}),
expect.any(Function), // the `next` function
);
});

it('attaches client IP and request headers if options are set', async () => {
const scope = { setUser: vi.fn(), setPropagationContext: vi.fn() };
// @ts-expect-error, only passing a partial Scope object
const configureScopeSpy = vi.spyOn(SentryNode, 'configureScope').mockImplementation(cb => cb(scope));

const middleware = handleRequest({ trackClientIp: true, trackHeaders: true });
const ctx = {
request: {
method: 'GET',
url: '/users',
headers: new Headers({
'some-header': 'some-value',
}),
},
clientAddress: '192.168.0.1',
params: {},
url: new URL('https://myDomain.io/users/'),
};
const next = vi.fn();

// @ts-expect-error, a partial ctx object is fine here
await middleware(ctx, next);

expect(configureScopeSpy).toHaveBeenCalledTimes(1);
expect(scope.setUser).toHaveBeenCalledWith({ ip_address: '192.168.0.1' });

expect(startSpanSpy).toHaveBeenCalledWith(
expect.objectContaining({
data: expect.objectContaining({
headers: {
'some-header': 'some-value',
},
}),
}),
expect.any(Function), // the `next` function
);
});
});

describe('interpolateRouteFromUrlAndParams', () => {
it.each([
['/foo/bar', {}, '/foo/bar'],
['/users/123', { id: '123' }, '/users/[id]'],
['/users/123', { id: '123', foo: 'bar' }, '/users/[id]'],
['/lang/en-US', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]'],
['/lang/en-US/posts', { lang: 'en', region: 'US' }, '/lang/[lang]-[region]/posts'],
])('interpolates route from URL and params %s', (rawUrl, params, expectedRoute) => {
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});

it('handles params across multiple URL segments in catchall routes', () => {
// Ideally, Astro would let us know that this is a catchall route so we can make the param [...catchall] but it doesn't
expect(
interpolateRouteFromUrlAndParams('/someroute/catchall-123/params/foo/bar', {
catchall: 'catchall-123/params/foo',
params: 'foo',
}),
).toEqual('/someroute/[catchall]/bar');
});

it("doesn't replace partially matching route segments", () => {
const rawUrl = '/usernames/username';
const params = { name: 'username' };
const expectedRoute = '/usernames/[name]';
expect(interpolateRouteFromUrlAndParams(rawUrl, params)).toEqual(expectedRoute);
});
});