Uh oh!
There was an error while loading. Please reload this page.
feat(node): Add Hapi Integration - #9539
Merged
Merged
Conversation
onurtemizkanforce-pushed
the
onur/hapi-integration
branch
from
November 13, 2023 13:12
0b5d80c to
ddc49b1Comparemydea
reviewed
Nov 14, 2023
| @@ -0,0 +1,163 @@ | |||
| import type { Boom } from '@hapi/boom'; | |||
Member
There was a problem hiding this comment.
We should not/cannot use types like these, as then we need to add hapi as a dependency 😬 let's just inline the types we need in here!
Comment on lines
+68
to
+99
| const sentryRequest = https.request( | ||
| sentryIngestUrl, | ||
| { headers: proxyRequest.headers, method: proxyRequest.method }, | ||
| sentryResponse => { | ||
| sentryResponse.addListener('data', (chunk: Buffer) => { | ||
| proxyResponse.write(chunk, 'binary'); | ||
| sentryResponseChunks.push(chunk); | ||
| }); | ||
| sentryResponse.addListener('end', () => { | ||
| eventCallbackListeners.forEach(listener => { | ||
| const rawSentryResponseBody = Buffer.concat(sentryResponseChunks).toString(); | ||
| const data: SentryRequestCallbackData = { | ||
| envelope: parseEnvelope(proxyRequestBody, new TextEncoder(), new TextDecoder()), | ||
| rawProxyRequestBody: proxyRequestBody, | ||
| rawSentryResponseBody, | ||
| sentryResponseStatusCode: sentryResponse.statusCode, | ||
| }; | ||
| listener(Buffer.from(JSON.stringify(data)).toString('base64')); | ||
| }); | ||
| proxyResponse.end(); | ||
| }); | ||
| sentryResponse.addListener('error', err => { | ||
| throw err; | ||
| }); | ||
| proxyResponse.writeHead(sentryResponse.statusCode || 500, sentryResponse.headers); | ||
| }, | ||
| ); |
Check failure
Code scanning / CodeQL
Server-side request forgery
Contributor
size-limit report 📦
|
onurtemizkanforce-pushed
the
onur/hapi-integration
branch
3 times, most recently
from
November 18, 2023 06:05
0729c7f to
c5c9d9cCompareonurtemizkan
marked this pull request as ready for review
November 18, 2023 06:24
mydea
reviewed
Nov 20, 2023
| } | ||
| function sendErrorToSentry(errorData: object): void { | ||
| captureException(errorData, scope => { |
Member
There was a problem hiding this comment.
Note to self: if we merge #9590 first, update this later!
Member
There was a problem hiding this comment.
OK, merged this in yet, so we can refactor this to this instead:
captureException(errorData,{mechanism: {type: 'hapi',handled: false,data: {function: 'hapiErrorPlugin',},}});mydea
reviewed
Nov 20, 2023
| export const hapiErrorPlugin = { | ||
| name: 'SentryHapiErrorPlugin', | ||
| version: '0.0.1', |
Member
There was a problem hiding this comment.
let's make this SDK_VERSION, which we can import from core?
mydea
reviewed
Nov 20, 2023
| /* eslint-disable @typescript-eslint/no-empty-interface */ | ||
| /* eslint-disable @typescript-eslint/no-namespace */ | ||
| // Vendored and simplified from: |
Member
There was a problem hiding this comment.
Could we possibly add the versions here we vendored from, may make future updating easier? 😅
mydea
reviewed
Nov 20, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
some small comments, but overall this looks great! nice E2E tests 🎉
onurtemizkan
commented
Nov 24, 2023
ContributorAuthor
Thanks for the review @mydea. I updated the PR 👍 |
onurtemizkanforce-pushed
the
onur/hapi-integration
branch
from
November 27, 2023 13:50
3561347 to
d8bb0e1Comparemydea
approved these changes
Dec 4, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
back from my vacation, this looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #9344
Adds a new node integration for Hapi framework.
Also exports a Hapi plugin to capture errors when the tracing instrumentation from
node-experimentalis used.Can be used with
node-experimental(Sample Error Event) like:Also can be used from
@sentry/nodewith tracing (Errored Transaction, Successful Transaction) and error tracking (Event) like: