feat(node): Rework ANR to use worker script via an integration by timfish · Pull Request #9823 · getsentry/sentry-javascript

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish · 2023-12-13T18:19:35Z

This PR reworks Node ANR detection to use a worker thread. Workers are usually started via a path to a source file but this can cause issues when bundlers are used. Instead, the worker code is bundled and included in the source as a base64 string which can be used to launch a worker via a data URL. The base64 code comes in at around 45KB.

Closes#9324 by adding trace context.

Also aids with solving getsentry/sentry-electron#784

~~Relies on #9018 being merged so module and app/device context are included.~~

Positives 👍

No extra processes
Only 10-15MB memory overhead (vs at least 50MB for a child process)
Uses inspector API so we can remove the websockets implementation
Doesn't require special cases/setup for Electron main process
No longer runs the app entry point again as the child process code
- Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app execution in the child
- Less confusing setup and less chance of running the app twice

Negatives 👎

Minimum supported Node version for ANR detection becomes v16 because Node 14 does not support data URLs for workers 😢

Usage

import*asSentryfrom'@sentry/node';Sentry.init({dsn: 'https://public@dsn.ingest.sentry.io/1337',integrations: [newSentry.Integrations.Anr({captureStackTrace: true,anrThreshold: 200})],});

…anr-worker-thread

…nto anr-worker-from-base64-script

anonrig · 2023-12-14T15:08:08Z

+
+const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);
+
+parentPort?.on('message', (msg: { session: Session | undefined }) => {


Suggested change
parentPort?.on('message',(msg: {session: Session|undefined})=>{
parentPort?.on('message',(msg: {session?: Session})=>{

…base64-script

+
+ const testScriptPath = path.resolve(__dirname, 'legacy.js');
+
+ childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {


…nto anr-worker-from-base64-script

…base64-script

timfish · 2023-12-19T18:17:39Z

This PR now also fetches the parentSpanId and I added some test asserts that check the app/device/os/culture context gets added to events.

lforst · 2023-12-20T09:57:23Z

Emitting files into our src folder is very bad for a lot of reasons - caching, build order, general reproducability. We need to change this.

lforst · 2023-12-20T09:57:57Z

Pls do not do this immediately as I am restructuring our rollup configs right now and I am hotfixing this but this is high prio.

lforst · 2023-12-20T11:50:59Z

Sorry I have to revert this PR. It has too many bad implications with the build process.

#9823)" This reverts commit ce9efc7.

#9823)" (#9931)

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged

timfish added 10 commits December 9, 2023 16:58

feat(node): Use worker thread for ANR detection
ed4a316

Remove utility
14fe3a5

PR feedback
e5c82dd

Merge branch 'develop' into fix/anr-worker-thread
d246581

remove outdated comments
dce3684

Merge remote-tracking branch 'origin/fix/anr-worker-thread' into fix/…
2ca69ca
…anr-worker-thread

use getWorkerThreads
3042553

Merge branch 'develop' into fix/anr-worker-thread
dad68a1

Merge branch 'develop' into fix/anr-worker-thread
61dd30f

feat(node): Rework ANR to use worker script via an integration
33e1ce0

timfish mentioned this pull request Dec 13, 2023
feat(node): Use worker thread for ANR detection #9789
Closed

timfish added 6 commits December 13, 2023 19:31

Bodge the build and add platform
97b09bb

also build before test
b2a1907

Work on build
8b6289f

Merge branch 'develop' into anr-worker-from-base64-script
0486f12

Only node 16 😢
91c19b9

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
26b4ebe
…nto anr-worker-from-base64-script

timfish marked this pull request as ready for review December 13, 2023 20:56

This comment was marked as outdated.
Sign in to view

a few worker simplifications
d098a53

timfish requested a review from AbhiPrasad December 14, 2023 10:08

AbhiPrasad requested a review from anonrig December 14, 2023 14:34

anonrig reviewed Dec 14, 2023
View reviewed changes

timfish added 3 commits December 17, 2023 11:53

PR review comments
27ebe02

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
624f097
…base64-script

Only test node >= 16
94af9ec

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadpackages/node/src/index.ts Outdated

timfish added 2 commits December 18, 2023 15:23

Include and test the old deprecated API
40f25d2

Merge branch 'develop' into anr-worker-from-base64-script
7ef8050

github-advanced-securityAI found potential problems Dec 18, 2023
View reviewed changes

timfish added 3 commits December 18, 2023 15:44

Linting
0c71dcc

Merge remote-tracking branch 'origin/anr-worker-from-base64-script' i…
930969b
…nto anr-worker-from-base64-script

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
3de4144
…base64-script

AbhiPrasad reviewed Dec 18, 2023
View reviewed changes

Comment threadrollup/bundleHelpers.js
Comment threadpackages/node/src/integrations/anr/worker.ts Outdated
Comment threadpackages/node/src/integrations/anr/worker.ts
Comment threadpackages/node/src/integrations/anr/index.ts

timfish added 4 commits December 19, 2023 18:51

Merge remote-tracking branch 'upstream/develop' into anr-worker-from-…
b2d4b66
…base64-script

remove isAnrChildProcess usage
f0ac67e

Include parentSpanId in trace context
41cc61d

Ensure we get app/device/os/culture context with ANR events
4a7c4fc

Fix test
6271c85

AbhiPrasad approved these changes Dec 19, 2023
View reviewed changes

AbhiPrasad merged commit ce9efc7 into getsentry:developDec 19, 2023

timfish deleted the anr-worker-from-base64-script branch December 20, 2023 04:17

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
725954c
#9823)" This reverts commit ce9efc7.

lforst pushed a commit that referenced this pull request Dec 20, 2023
Revert "feat(node): Rework ANR to use worker script via an integration (
fdd4c62
#9823)" (#9931)

timfish restored the anr-worker-from-base64-script branch December 20, 2023 14:16

timfish mentioned this pull request Dec 20, 2023
feat(node): Rework ANR to use worker script via an integration #9945
Merged


		const { poll } = watchdogTimer(createHrTimer, options.pollInterval, options.anrThreshold, watchdogTimeout);

		parentPort?.on('message', (msg: { session: Session \| undefined }) => {

	parentPort?.on('message',(msg: {session: Session\|undefined})=>{
	parentPort?.on('message',(msg: {session?: Session})=>{


		const testScriptPath = path.resolve(__dirname, 'legacy.js');

		childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {

Uh oh!

Uh oh!

Conversation

timfish commented Dec 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Usage

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrigDec 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timfish commented Dec 19, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

timfish commented Dec 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Usage

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrigDec 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timfish commented Dec 19, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

lforst commented Dec 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

timfish commented Dec 13, 2023•
edited
Loading

timfish commented Dec 13, 2023•
edited
Loading

timfish commented Dec 13, 2023•
edited
Loading

timfish commented Dec 13, 2023•
edited
Loading