ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handling by Lms24 · Pull Request #9901 · getsentry/sentry-javascript

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 · 2023-12-18T17:30:23Z

This PR improves our logic to filter out "Not Found" errors in our server-side handleError hook wrapper:

We now use SvelteKit 2.0 - native error properties (status~~and message~~) to check for "Not Found" errors
Adjusted types for type safety and backwards compatibility with SvelteKit 1.x where the ~~two properties~~ property don't exist.
Updated Sveltekit to 2.0 in our dev dependency to work with latest types.

Not really happy with the two @ts-expect-error but I didn't find anything that looks nicer and still guarantees type safety when we work with the input object. Definitely open to ideas!

ref #9851

Lms24 · 2023-12-18T17:50:22Z

+// TODO: add backwards-compatible type for kit 1.x (soon)
+type HandleClientErrorInput = Parameters<HandleClientError>[0];


Will add this in a follow-up PR where I'll add filtering out "Not Found" errors on the client side

Lms24 · 2023-12-18T17:50:59Z

 });

- it.each([new Error(), redirect(301, '/users/id'), 'string error', { status: 404 }, { body: 'Not found' }])(
+ it.each([new Error(), { status: 301, message: '/users/id' }, 'string error', { status: 404 }, { body: 'Not found' }])(


calling redirect throws since Sveltekit 2.0, so I rewrote this test to what redirect used to return in kit 1.x (this is not breaking or relevant for kit 2.0)

AbhiPrasad · 2023-12-18T17:58:48Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


l: is it just fine to only check status code?

I added the check for both, message and status because they're not determined identically:
https://github.com/sveltejs/kit/blob/fc8389c9cf42a02665edd8aa7a6840fe982134c9/packages/kit/src/utils/error.js#L26-L39
So while I think it doesn't happen at the moment, a HttpError could be thrown with a 404 status code and another message. If we only check for 404, we'd also filter out that error - whatever it is. Are we fine with that?

I would assume any 404 errors are not useful, but perhaps it's good to be conservative on what we filter for now.

I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

I changed the check to only consider the 404 status. You're right - we shouldn't capture other 404s either.

lforst · 2023-12-19T08:45:53Z

+ const { error, event, status, message } = input;
+
+ // SvelteKit 2.0 offers a reliable way to check for a Not Found error:
+ if (status === 404 && message === 'Not Found') {


I would not report 404s as errors. Filtering by transaction/span status should be powerful enough for users to achieve what they want.

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

Lms24 changed the title ~~ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling~~ref(sveltekit): Improve SvelteKit 2.0 Not Found server error handlingDec 18, 2023

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from 87f2c17 to 8cfeb81Compare December 18, 2023 17:43

Lms24 commented Dec 18, 2023
View reviewed changes

Lms24 requested review from AbhiPrasad and lforst December 18, 2023 17:51

Lms24 marked this pull request as ready for review December 18, 2023 17:51

Lms24 mentioned this pull request Dec 18, 2023
Support Sveltekit v2 #9851
Closed

Lms24 self-assigned this Dec 18, 2023

AbhiPrasad approved these changes Dec 18, 2023
View reviewed changes

Lms24 mentioned this pull request Dec 18, 2023
fix(sveltekit): Avoid capturing 404 errors on client side #9902
Merged

lforst approved these changes Dec 19, 2023
View reviewed changes

Lms24 added 5 commits December 19, 2023 13:08

ref(sveltekit): Improve SvelteKit 2.0 Not Found error handling
a14104c

add test
b40dfe5

fix redirect now being thrown (only relevant in test)
e5df24e

fix type error in client handleError
44abc21

only check status
51788bc

Lms24 force-pushed the lms/ref-sveltekit-improve-server-handleError branch from a4e6a66 to 51788bcCompare December 19, 2023 12:18

Lms24 enabled auto-merge (squash) December 19, 2023 12:20

Lms24 merged commit cef3621 into developDec 19, 2023

Lms24 deleted the lms/ref-sveltekit-improve-server-handleError branch December 19, 2023 12:35

		// TODO: add backwards-compatible type for kit 1.x (soon)
		type HandleClientErrorInput = Parameters<HandleClientError>[0];

Uh oh!

Uh oh!

Conversation

Lms24 commented Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Lms24 commented Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Lms24 commented Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24Dec 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 commented Dec 18, 2023•
edited
Loading

Lms24Dec 18, 2023•
edited
Loading

Lms24 commented Dec 18, 2023•
edited
Loading

Lms24Dec 18, 2023•
edited
Loading

Lms24 commented Dec 18, 2023•
edited
Loading

Lms24Dec 18, 2023•
edited
Loading

Lms24 commented Dec 18, 2023•
edited
Loading