[4.x] Rollback to is_a() to ignore exceptions instead of in_array()

[fmata]

Hello,

#1503 reintroduced ignore_exceptions in config and deprecated IgnoreErrorsIntegration. As reported in #1503 (comment) the behavior changed : before we could list interfaces or class hierarchy to ignore, after we must list all children exceptions (dozens or more in a decent project as stated by @stayallive).

It has been merged and released in the minor release 3.17. But deprecates a feature whithout upgrade path to have the exact
same feature in a minor release is not sem ver compliant.

Can you merge my PR and release a new patch version to rollback as before 3.17 ?

Thanks

[cleptric]

While I agree that is_a might be beneficial, making these changes now can have worse effects on people who already use the new option. Hence, I'm not moving forward with this for now.

We can address this in the next major version of the SDK, which we already started working on.

[fmata]

@cleptric beneficial or not, it was the behavior until a minor release (3.17) which changed it without warning or upgrade note. The mistake is here, 3.17 already breaks many apps by alerting with false positives. Revert a breaking change of a documented feature is sem-ver compliant.

Mistake can happens :) but do not respect sem-ver is a bad signal for your users.

Or maybe there is a solution not deprecated. Can you give me an hint ?

[cleptric]

Can you clarify what you mean by breaks many apps by alerting with false positives?
I also don't see any breaking change introduced in 3.17. The IgnoreErrorsIntegration works exactly as to prior versions. Hence, I find the claim us not following semver a bit exaggerated.

[fmata]

Using sentry/sentry-symfony,

Before 3.17 :

sentry:
dsn: '%env(SENTRY_DSN)%'options:
environment: '%app.deploy_env%'integrations:
- Sentry\Integration\IgnoreErrorsIntegrationsend_default_pii: trueregister_error_listener: falseregister_error_handler: falsemonolog:
handlers:
sentry:
type: sentrylevel: !php/const Monolog\Logger::ERRORhub_id: Sentry\State\HubInterfaceservices:
Sentry\Integration\IgnoreErrorsIntegration:
arguments:
$options:
ignore_exceptions:
- ApiPlatform\Symfony\Validator\Exception\ValidationException
- Symfony\Component\HttpKernel\Exception\HttpExceptionInterface
- Symfony\Component\Security\Core\Exception\AccessDeniedException

All children of HttpExceptionInterface (NotFoundHttpException, BadRequestHttpException and so on...) are ignored.

After upgrade to >= 3.17, we removed all deprecated calls :

sentry:
dsn: '%env(SENTRY_DSN)%'options:
environment: '%app.deploy_env%'ignore_exceptions:
- ApiPlatform\Symfony\Validator\Exception\ValidationException
- Symfony\Component\HttpKernel\Exception\HttpExceptionInterface
- Symfony\Component\Security\Core\Exception\AccessDeniedExceptionsend_default_pii: trueregister_error_listener: falseregister_error_handler: falsemonolog:
handlers:
sentry:
type: sentrylevel: !php/const Monolog\Logger::ERRORhub_id: Sentry\State\HubInterface

All children of HttpExceptionInterface (NotFoundHttpException, BadRequestHttpException and so on...) are sent to sentry and notify the team : false positives.

[cleptric]

I recommend reverting back to IgnoreErrorsIntegration if you rely on the is_a check. In the next major version, we'll add this to ignore_exceptions as well as RegEx support.

[stayallive]

Excellent change. Going to make it much easier to ignore a certain class of exceptions 👍

[cleptric]

Will fix CI later.