Skip to content

Add API to set custom Span timestamps - #1770

Merged
antonpirker merged 2 commits into
antonpirker/1687-basic-otel-support-2-instrumenterfrom
antonpirker/1687-basic-otel-support-3b-timestamps
Nov 30, 2022
Merged

Add API to set custom Span timestamps#1770
antonpirker merged 2 commits into
antonpirker/1687-basic-otel-support-2-instrumenterfrom
antonpirker/1687-basic-otel-support-3b-timestamps

Conversation

@antonpirker

@antonpirkerantonpirker commented Nov 30, 2022

Copy link
Copy Markdown
Contributor
  • When creating a Span/Transaction a start_timestamp can be given.
  • When a Span/Transaction is finished a end_timestamp can be given.

Both default to "now" in UTC.

@antonpirkerantonpirker added this to the Basic OTel support milestone Nov 30, 2022
@antonpirkerantonpirker mentioned this pull request Nov 30, 2022
Closed
@sl0thentr0py
sl0thentr0py changed the base branch from master to antonpirker/1687-basic-otel-support-3a-set-contextNovember 30, 2022 13:59
sl0thentr0py
sl0thentr0py requested changes Nov 30, 2022
View reviewed changes
Comment threadsentry_sdk/tracing.py Outdated
Base automatically changed from antonpirker/1687-basic-otel-support-3a-set-context to antonpirker/1687-basic-otel-support-2-instrumenterNovember 30, 2022 15:53
@antonpirker
antonpirker merged commit 4cb573b into antonpirker/1687-basic-otel-support-2-instrumenterNov 30, 2022
@antonpirker
antonpirker deleted the antonpirker/1687-basic-otel-support-3b-timestamps branch November 30, 2022 15:54
antonpirker added a commit that referenced this pull request Dec 1, 2022
@antonpirker
Add instrumenter config to switch between Otel and Sentry instrumenta…
46697dd
…tion. (#1766)
* Add instrumenter config to switch between Sentry and OTel instrumentation.
* Add API to set arbitrary context in Transaction. (#1769)
* Add API to set custom Span timestamps (#1770)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0pysl0thentr0pysl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Basic OTel support

Development

Successfully merging this pull request may close these issues.

2 participants

@antonpirker@sl0thentr0py