Skip to content

Basic OTel support - #1772

Merged
antonpirker merged 19 commits into
masterfrom
antonpirker/1687-basic-otel
Dec 14, 2022
Merged

Basic OTel support#1772
antonpirker merged 19 commits into
masterfrom
antonpirker/1687-basic-otel

Conversation

@antonpirker

@antonpirkerantonpirker commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

Adding basic OpenTelementry (OTel) support to the Sentry SDK:

  • Adding a OTel SpanProcessor that can receive spans form OTel and then convert them into Sentry Spans and send them to Sentry.
  • Adding a OTel Propagator that can receive and propagate trace headers (Baggage) to keep distributed tracing intact.

@antonpirkerantonpirker mentioned this pull request Dec 1, 2022
Closed
@antonpirkerantonpirker added this to the Basic OTel support milestone Dec 1, 2022
@antonpirkerantonpirker changed the title OTel support (added SpanProcessor and Propagator)Baseic OTel supportDec 1, 2022
@antonpirkerantonpirker changed the title Baseic OTel supportBasic OTel supportDec 1, 2022
@sl0thentr0py
sl0thentr0py self-requested a review December 5, 2022 13:08
@sl0thentr0py

sl0thentr0py commented Dec 5, 2022

Copy link
Copy Markdown
Member

we need a line in setup.py in extras_require

sl0thentr0py
sl0thentr0py reviewed Dec 5, 2022
View reviewed changes

@sl0thentr0pysl0thentr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed SpanProcessor

Comment threadsentry_sdk/tracing.py Outdated
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py Outdated
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py Outdated
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py
sl0thentr0py
sl0thentr0py previously requested changes Dec 5, 2022
View reviewed changes

@sl0thentr0pysl0thentr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright did propagator too, will do another round once all this is changed

Comment threadsentry_sdk/integrations/opentelemetry/propagator.py
Comment threadsentry_sdk/integrations/opentelemetry/propagator.py Outdated
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py
Comment threadsentry_sdk/integrations/opentelemetry/span_processor.py
Comment threadsentry_sdk/integrations/opentelemetry/propagator.py Outdated
Comment threadsentry_sdk/integrations/opentelemetry/propagator.py
Comment threadsentry_sdk/integrations/opentelemetry/propagator.py Outdated
@smeubanksmeubank linked an issue Dec 7, 2022 that may be closed by this pull request
Basic OpenTelemetry (OTEL) Support #1687
Closed
@antonpirker
antonpirkerforce-pushed the antonpirker/1687-basic-otel branch from bf57f69 to 031e79aCompareDecember 13, 2022 10:37
@antonpirker
antonpirker merged commit d0eed0e into masterDec 14, 2022
@antonpirker
antonpirker deleted the antonpirker/1687-basic-otel branch December 14, 2022 15:12
@tonyo
tonyo restored the antonpirker/1687-basic-otel branch December 16, 2022 16:05
@tonyo
tonyo deleted the antonpirker/1687-basic-otel branch December 20, 2022 13:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0pysl0thentr0pyAwaiting requested review from sl0thentr0py
1 more reviewer
@vladanpaunovicvladanpaunovicvladanpaunovic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Basic OTel support

Development

Successfully merging this pull request may close these issues.

Basic OpenTelemetry (OTEL) Support

3 participants

@antonpirker@sl0thentr0py@vladanpaunovic