Skip to content

feat: tracing prototype - #372

Merged
untitaker merged 54 commits into
masterfrom
wip/sessiontracking
Jul 5, 2019
Merged

feat: tracing prototype#372
untitaker merged 54 commits into
masterfrom
wip/sessiontracking

Conversation

@untitaker

@untitakeruntitaker commented May 22, 2019•
edited
Loading

Copy link
Copy Markdown
Member

No idea how the event payload is supposed to look, just went by what armin patched into semaphore. We get an unlabeled event in Sentry right now

@mitsuhikomitsuhiko changed the title [WIP] feat: Prototype of session tracking[WIP] feat: tracing prototypeMay 24, 2019
dcramer
dcramer reviewed May 24, 2019
View reviewed changes
Comment threadsentry_sdk/transport.py
@untitaker
untitakerforce-pushed the wip/sessiontracking branch from 9cde1cd to 4881600CompareMay 29, 2019 08:49
@untitaker
untitakerforce-pushed the wip/sessiontracking branch from 4881600 to 270ff43CompareMay 29, 2019 09:00
@untitakeruntitaker changed the title [WIP] feat: tracing prototypefeat: tracing prototypeJun 1, 2019
bruno-garcia
bruno-garcia requested changes Jun 11, 2019
View reviewed changes
Comment threadsentry_sdk/consts.py Outdated
Comment threadsentry_sdk/consts.py Outdated
Comment threadsentry_sdk/hub.py Outdated
Comment threadsentry_sdk/hub.py Outdated
Comment threadsentry_sdk/hub.py Outdated
Comment threadsentry_sdk/integrations/wsgi.py Outdated
Comment threadsentry_sdk/tracing.py
Comment threadsentry_sdk/tracing.py Outdated
Comment threadsentry_sdk/tracing.py
Comment threadtests/test_tracing.py
from sentry_sdk import Hub


@pytest.mark.parametrize("sample_rate", [0.0, 1.0])

@bruno-garciabruno-garciaJun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the test!?!??! :D

@untitakeruntitakerJun 11, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soon (tm)

@bruno-garcia
bruno-garcia self-requested a review June 19, 2019 16:32
HazAT
HazAT requested changes Jun 21, 2019
View reviewed changes
Comment threadsentry_sdk/tracing.py
same_process_as_parent=True,
sampled=None,
transaction=None,
op=None,

@HazATHazATJun 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we make operation required?

@untitakeruntitakerJun 21, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For transaction/trace spans, none of the Pytohn SDK's integrations set either OP or description. Only for child spans.

@untitakeruntitakerJun 21, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to make more attrs required I'd like to discuss what the difference between transaction and description is

@untitaker
untitakerforce-pushed the wip/sessiontracking branch from 0554455 to 60ec0ccCompareJuly 4, 2019 12:23
@untitaker
untitaker merged commit ca0ba7f into masterJul 5, 2019
@untitaker
untitaker deleted the wip/sessiontracking branch July 5, 2019 12:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcramerdcramerdcramer left review comments
@HazATHazATHazAT requested changes
@bruno-garciabruno-garciabruno-garcia approved these changes
@mitsuhikomitsuhikoAwaiting requested review from mitsuhiko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@untitaker@dcramer@HazAT@bruno-garcia