feat(profiling): add platform header to the chunk item-type in the envelope

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.

[viglia]

We need to send the platform as part of the headers in the chunk item-type as this is the header that relay is checking to manage rate limiting.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5715734) to head (1002ac6).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@ Coverage Diff @@## master #4178 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.04% 
==========================================
Files 141 141 Lines 15736 15736 Branches 2675 2675 ==========================================
- Hits 12520 12515 -5 - Misses 2369 2376 +7 + Partials 847 845 -2 

Files with missing lines	Coverage Δ
sentry_sdk/envelope.py	80.09% <ø> (ø)

... and 6 files with indirect coverage changes

[phacops]

I wouldn't mind to avoid any potential None value here. Can we hardcode the same value we set in profile_chunk? Or only add the headers if we have a key platform?

[viglia]

@phacops I could throw-in an extra check if you wish but just fyi: if profile_chunk.get("platform") returns None it means the platform is not set at the payload either and therefore the whole profile would be rejected as it does not comply to the Relay defined schema (platform is a mandatory field).

[phacops]

True. I'm just allergic to null values.