Skip to content

Trying to prevent the grpc setup from being flaky - #4233

Merged
antonpirker merged 14 commits into
masterfrom
antonpirker/fix/grpc-test-flakyness
Apr 3, 2025
Merged

Trying to prevent the grpc setup from being flaky#4233
antonpirker merged 14 commits into
masterfrom
antonpirker/fix/grpc-test-flakyness

Conversation

@antonpirker

@antonpirkerantonpirker commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Automatically select a port and not set it by hand also make creating of the channel more stable.

@antonpirker
antonpirker requested a review from a team as a code ownerApril 2, 2025 15:16
@codecov

codecovBot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5147ab9) to head (bde3e15).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## master #4233 +/- ##
==========================================
+ Coverage 79.52% 79.53% +0.01% 
==========================================
Files 142 142 Lines 15898 15898 Branches 2721 2721 ==========================================
+ Hits 12643 12645 +2 
Misses 2389 2389 + Partials 866 864 -2 

see 4 files with indirect coverage changes

@antonpirker
antonpirker marked this pull request as draft April 3, 2025 09:49
@antonpirker
antonpirker marked this pull request as ready for review April 3, 2025 12:10
@antonpirker

Copy link
Copy Markdown
ContributorAuthor

I have now run the tests five times in a row without the grpc tests being flaky, so I guess this works. (the last time another flaky test failed, but it was not grpc)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@antonpirker@sentrivana