feat(wsgi): Migrate to span first by sentrivana · Pull Request #5988 · getsentry/sentry-python

sentrivana · 2026-04-13T11:29:36Z

Description

Make the WSGI integration span first ready.

Also, set an additional attribute (user.ip_address) in ASGI.

Recommended to review with Ignore whitespace on.

Issues

Reminders

Please add tests to validate your changes, and lint your code using tox -e linters.
Add GH Issue ID & Linear ID (if applicable)
PR title should use conventional commit style (feat:, fix:, ref:, meta:)
For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

github-actions · 2026-04-13T13:42:06Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-04-13T14:08:48Z

Codecov Results 📊

✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 6.83s

All tests are passing successfully.

❌ Patch coverage is 7.81%. Project has 15327 uncovered lines.

Files with missing lines (3)

File	Patch %	Lines
`scope.py`	65.78%	⚠️ 297 Missing and 74 partials
`wsgi.py`	17.84%	⚠️ 152 Missing
`_asgi_common.py`	13.70%	⚠️ 63 Missing

Generated by Codecov Action

github-actions · 2026-04-13T14:08:48Z

Codecov Results 📊

✅ 49 passed | ⏭️ 3 skipped | Total: 52 | Pass Rate: 94.23% | Execution Time: 12.36s

📊 Comparison with Base Branch

Metric	Change
Total Tests	—
Passed Tests	—
Failed Tests	—
Skipped Tests	—

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 7.81%. Project has 15640 uncovered lines.
❌ Project coverage is 26.7%. Comparing base (base) to head (head).

Files with missing lines (5)

File	Patch %	Lines
`scope.py`	61.75%	⚠️ 332 Missing and 73 partials
`asgi.py`	15.38%	⚠️ 176 Missing
`wsgi.py`	20.65%	⚠️ 123 Missing
`_wsgi_common.py`	23.75%	⚠️ 122 Missing
`_asgi_common.py`	13.70%	⚠️ 63 Missing

Coverage diff

@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 26.75% 26.70% -0.05%
==========================================
Files 191 191 —
Lines 21281 21336 +55
Branches 7006 7036 +30
==========================================
+ Hits 5692 5696 +4- Misses 15589 15640 +51- Partials 490 490 —

Generated by Codecov Action

sentrivana · 2026-04-14T09:52:36Z

 return event_processor
+
+
+def _get_request_attributes(


This is essentially a port of the event processor

sentrivana · 2026-04-14T09:53:33Z

 self, custom_sampling_context: "dict[str, Any]"
 ) -> None:
- self.get_active_propagation_context()._set_custom_sampling_context(
+ self.get_current_scope().get_active_propagation_context()._set_custom_sampling_context(


This change was necessary as we're now always starting spans, regardless of type (segment or child), on the current scope instead of the isolation scope, so we also need to use the propagation context from there.

linear-code · 2026-04-14T10:02:10Z

PY-2374 Migrate wsgi to span first

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 54064a5. Configure here.}

### Description Make the WSGI integration span first ready. Also, set an additional attribute (`user.ip_address`) in ASGI. Recommended to review with Ignore whitespace on. #### Issues * Closesgetsentry#6072 * Closes https://linear.app/getsentry/issue/PY-2374/migrate-wsgi-to-span-first

sentrivana added 27 commits March 30, 2026 14:56

feat(asgi): Migrate away from event processor in span first
282ba35

fixes
e2484bd

Merge branch 'master' into ivana/migrate-asgi-event-processor
51af434

.
5c3174f

.
b270e5a

.
e93fd1b

capture_items
7cde973

Merge branch 'master' into ivana/migrate-asgi-event-processor
ef9e640

.
df3f3af

.
babb3bd

no annotatedvalues
75429dc

.
d9d7674

.
32e4191

more tests
5cecf97

Merge branch 'master' into ivana/migrate-asgi-event-processor
a39337b

.
7fb4863

.
7490fe3

.
c11e8f1

Merge branch 'master' into ivana/migrate-asgi-event-processor
982d471

ruff
10bf7c9

source is not default anymore
87d00e6

Merge branch 'master' into ivana/migrate-asgi-event-processor
507306f

mypy
eebc385

var name
e388901

Merge branch 'master' into ivana/migrate-asgi-event-processor
77b9298

feat(wsgi): Migrate WSGI integration to span first
f33e407

fixes, more tests
a2ff75c

sentrivana added the skip-changelog label Apr 13, 2026

Base automatically changed from ivana/migrate-asgi-event-processor to masterApril 13, 2026 13:41

Merge branch 'master' into ivana/migrate-wsgi-to-span-first
6a8d60f

sentrivana added 2 commits April 13, 2026 16:15

dont set on scope
86fd48a

move imports
9648022

sentry-wardenBot reviewed Apr 13, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/wsgi.py Outdated

sentry-wardenBot reviewed Apr 13, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/_wsgi_common.py Outdated

sentrivana added 2 commits April 14, 2026 11:16

.
0d85002

fix
54064a5

sentrivana commented Apr 14, 2026
View reviewed changes

sentrivana marked this pull request as ready for review April 14, 2026 10:02

sentrivana requested a review from a team as a code owner April 14, 2026 10:02

cursorBot reviewed Apr 14, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/wsgi.py Outdated

set server.port as int
94532f6

alexander-alderman-webb approved these changes Apr 14, 2026
View reviewed changes

sentrivana merged commit 822b244 into masterApr 14, 2026
167 of 169 checks passed

sentrivana deleted the ivana/migrate-wsgi-to-span-first branch April 14, 2026 14:37

Navigation Menu

Uh oh!

feat(wsgi): Migrate to span first - #5988

feat(wsgi): Migrate to span first#5988
sentrivana merged 33 commits into
masterfrom
ivana/migrate-wsgi-to-span-first

sentrivana commented Apr 13, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 13, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 13, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

sentrivanaApr 14, 2026

Uh oh!

sentrivanaApr 14, 2026•
edited
Loading

Uh oh!

linear-codeBot commented Apr 14, 2026

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sentrivana commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Reminders

Uh oh!

github-actionsBot commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actionsBot commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

github-actionsBot commented Apr 13, 2026

Codecov Results 📊

📊 Comparison with Base Branch

Uh oh!

Uh oh!

Uh oh!

sentrivanaApr 14, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivanaApr 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linear-codeBot commented Apr 14, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sentrivana commented Apr 13, 2026•
edited
Loading

github-actionsBot commented Apr 13, 2026•
edited
Loading

github-actionsBot commented Apr 13, 2026•
edited
Loading

sentrivanaApr 14, 2026•
edited
Loading