Uh oh!
There was an error while loading. Please reload this page.
feat(sqlalchemy): Support span streaming - #6132
Conversation
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.43s All tests are passing successfully. ❌ Patch coverage is 9.23%. Project has 14865 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sentrivana
left a comment
There was a problem hiding this comment.
Looking great overall! Just not sure about a handful of attributes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5efa060. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sentrivana
left a comment
There was a problem hiding this comment.
See https://github.com/getsentry/sentry-python/pull/6132/changes#r3154376220, otherwise LGTM
Uh oh!
There was an error while loading. Please reload this page.
Adapt `add_query_source()` to mirror changes to `add_http_request_source()` in getsentry#6084. Add `record_sql_queries_supporting_streaming()` based on `record_sql_queries()` so that the streaming path is not triggered for ORM integrations that have not yet been ported to the streaming trace lifecycle. Drop the `db.params`, `db.paramstyle`, `db.executemany`, and `db.cursor` attributes in streaming lifecycle mode. Replace deprecated `db.system` and `db.name` attributes with `db.system.name` and `db.namespace` attributes in the streaming lifecycle mode. Set `<unknown SQL query>` as the name when the description was previously `None`.

Description
Adapt
add_query_source()analogously to changes toadd_http_request_source()in #6084.Add
record_sql_queries_supporting_streaming()based onrecord_sql_queries()so that the streaming path is not triggered for other ORM integrations until they support the streaming trace lifecycle. Once the last ORM integration supports span-streaming the functions can be de-duplicated.Set
<unknown SQL query>as the name when the description was previouslyNone.Adapting Tests
sedcommands used for converting transaction context managers:sedcommands used for converting code source attributes:sedcommands used for converting event capture:sedcommands used for convertingop:sedcommands used for convertingdescription:sedcommands used for convertingdatatoattributes:sedcommands used for converting timestamps:Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)