Uh oh!
There was an error while loading. Please reload this page.
feat(stdlib): Support span streaming - #6154
Conversation
Codecov Results 📊✅ 2165 passed | ⏭️ 154 skipped | Total: 2319 | Pass Rate: 93.36% | Execution Time: 5m 2s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 12633 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1106fe4. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Port `http` and `subprocess` instrumentation to support the streaming lifecycle. Drop the `reason` and `subprocess.cwd` attributes in streaming lifecycle mode. Replace deprecated `http.method` and `url` attributes with `http.request.method` and `url.full` attributes in the streaming lifecycle mode. Use `url.query` and `url.fragment` instead of `http.query` and `http.fragment` in the streaming mode. Spans for some subprocess operations did not have a description. The value of the `sentry.op` attribute is used as the span name for the streaming path in these cases.

Description
Port patches for both
httpandsubprocesspackages.Spans for some subprocess operations did not have a description. The value of the
sentry.opattribute is also used as the name in the streaming path in these cases.In the streaming path, use
http.request.methodinstead ofhttp.methodur.fullinstead ofurlurl.queryinstead ofhttp.queryurl.fragment instead of http.fragmentDropped attributes:
reasonsubprocess.cwdTests for adding breadcrumbs based on spans have not been parametrized as breadcrumbs are not automatically created from spans with the new streaming lifecycle.
Adapting Tests
sedcommands used for converting transaction context managers:sed commands used for converting specific attributes:
sed -i '' 's/CODE_LINENO/CODE_LINE_NUMBER/g'
sed -i '' 's/CODE_FILEPATH/CODE_FILE_PATH/g'
sed -i '' 's/["tags"]["subprocess.pid"]/["attributes"][SPANDATA.PROCESS_PID]/g'
sedcommands used for converting event capture:sedcommands used for convertingop:sedcommands used for converting origin:sedcommands used for convertingdescription:sedcommands used for convertingdatatoattributes:sedcommands used for converting trace-related expressions:sedcommands used for converting timestamps:Issues
Closes#6066
Reminders
tox -e linters.feat:,fix:,ref:,meta:)