Uh oh!
There was an error while loading. Please reload this page.
feat(grpc): Support span streaming - #6204
Conversation
Codecov Results 📊✅ 146 passed | Total: 146 | Pass Rate: 100% | Execution Time: 21.58s All tests are passing successfully. ❌ Patch coverage is 2.04%. Project has 14293 uncovered lines. Files with missing lines (5)
Generated by Codecov Action |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sentrivana
left a comment
There was a problem hiding this comment.
LGTM. Can you please also add parent_span=None to sentry_sdk.traces.start_span calls where there were transactions previously? 🙏🏻
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a164341. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Drop the `type` attribute in streaming lifecycle mode. Use `rpc.method` and `rpc.response.status_code` instead of `method` and `code` in the streaming mode.

Description
In the streaming path, use
rpc.methodinstead ofmethodrpc.response.status_codeinstead ofcodeDropped attributes:
Adapting Tests
sedcommands used for converting transaction context managers:sed commands used for converting specific attributes:
sedcommands used for converting event capture:sedcommands used for convertingop:sedcommands used for converting origin:sedcommands used for convertingdescription:sedcommands used for convertingdatatoattributes:sedcommands for converting trace id:other test changes:
Issues
Closes#6027
Reminders
tox -e linters.feat:,fix:,ref:,meta:)