feat(tornado): Support span streaming by sl0thentr0py · Pull Request #6206 · getsentry/sentry-python

sl0thentr0py · 2026-05-05T13:32:27Z

Issues

resolves: Migrate tornado to span first #6067
resolves: PY-2369

linear-code · 2026-05-05T13:32:32Z

PY-2369 Migrate tornado to span first

github-actions · 2026-05-05T13:34:18Z

Codecov Results 📊

✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.61s

All tests are passing successfully.

❌ Patch coverage is 19.12%. Project has 14835 uncovered lines.

Files with missing lines (2)

File	Patch %	Lines
`tornado.py`	10.91%	⚠️ 147 Missing
`consts.py`	99.50%	⚠️ 2 Missing

Generated by Codecov Action

alexander-alderman-webb

Comment not blocking, looks good to me!

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1fa438a. Configure here.}

ericapisani · 2026-05-15T18:08:47Z

-def test_transactions(tornado_testcase, sentry_init, capture_events, handler, code):
- sentry_init(integrations=[TornadoIntegration()], traces_sample_rate=1.0)
- events = capture_events()
+def test_transactions(


Since this is now testing both segments and transactions, this test name should be updated

what should I update it to instead? I took wsgi tests as a reference and they're still called transactions

sentrivana

LGTM

Add span-streaming support to the Tornado integration. When span streaming is enabled, the request handler emits a StreamedSpan with HTTP request attributes (method, headers, query, URL, client address) and sets the response status on completion. The legacy transaction path is preserved for non-streaming mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

#### Issues * resolves: getsentry#6067 * resolves: PY-2369 --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sl0thentr0py requested a review from a team as a code owner May 5, 2026 13:32

sl0thentr0py changed the title ~~ref(tornado): migrate to span-first~~ref(tornado): migrate to span firstMay 5, 2026

sl0thentr0py changed the title ~~ref(tornado): migrate to span first~~feat(tornado): Support span streamingMay 5, 2026

alexander-alderman-webb approved these changes May 6, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py Outdated

sentrivana reviewed May 6, 2026
View reviewed changes

Comment threadtests/integrations/tornado/test_tornado.py Outdated
Comment threadtests/integrations/tornado/test_tornado.py Outdated
Comment threadsentry_sdk/integrations/tornado.py

ericapisani reviewed May 6, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py Outdated
Comment threadsentry_sdk/integrations/tornado.py Outdated
Comment threadsentry_sdk/integrations/tornado.py

sentrivana reviewed May 7, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch from 82de412 to a58538dCompare May 7, 2026 13:05

cursorBot reviewed May 7, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

cursorBot reviewed May 7, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py Outdated
Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch from 036b60a to 4f36419Compare May 15, 2026 12:34

sentryBot reviewed May 15, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py Outdated
Comment threadsentry_sdk/integrations/tornado.py Outdated

cursorBot reviewed May 15, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch 3 times, most recently from 4d430e9 to 2106ec2Compare May 15, 2026 13:06

sl0thentr0py requested review from ericapisani and sentrivana May 15, 2026 13:09

sl0thentr0py force-pushed the neel/span-first/tornado branch 3 times, most recently from e390c87 to ec6fd01Compare May 15, 2026 13:14

sentryBot reviewed May 15, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py Outdated

cursorBot reviewed May 15, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch from 4d4e44e to 4c597a4Compare May 15, 2026 13:52

sentryBot reviewed May 15, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

ericapisani reviewed May 15, 2026
View reviewed changes

sentrivana approved these changes May 18, 2026
View reviewed changes

sl0thentr0py added 4 commits May 18, 2026 14:06

address PR comments
b613b5a

req body
e6f564a

move request attrs to finally
0bf3d6f

bot comments
ee5bfee

sl0thentr0py force-pushed the neel/span-first/tornado branch from 4c597a4 to ee5bfeeCompare May 18, 2026 12:07

sentryBot reviewed May 18, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py enabled auto-merge (squash) May 18, 2026 12:27

fluff
ef0a5f9

sl0thentr0py force-pushed the neel/span-first/tornado branch from f76454c to ef0a5f9Compare May 18, 2026 12:33

sentryBot reviewed May 18, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/tornado.py

sl0thentr0py merged commit b4658eb into masterMay 18, 2026
156 checks passed

sl0thentr0py deleted the neel/span-first/tornado branch May 18, 2026 12:47

alexander-alderman-webb mentioned this pull request May 27, 2026
feat(openai-agents): Support span streaming #6404
Merged

sentry-release-botBot mentioned this pull request May 28, 2026
publish: getsentry/sentry-python@2.61.0 getsentry/publish#8297
Closed
6 tasks

Uh oh!

Conversation

sl0thentr0py commented May 5, 2026

Issues

Uh oh!

linear-codeBot commented May 5, 2026

Uh oh!

github-actionsBot commented May 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericapisaniMay 15, 2026

Choose a reason for hiding this comment

Uh oh!

sl0thentr0pyMay 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actionsBot commented May 5, 2026•
edited
Loading

sl0thentr0pyMay 18, 2026•
edited
Loading