Uh oh!
There was an error while loading. Please reload this page.
feat: Support feature flags in span first - #6234
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 12 passed | Total: 12 | Pass Rate: 100% | Execution Time: 4.07s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 11.11%. Project has 15637 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 33.18% 27.83% -5.35%
==========================================
Files 190 189 -1
Lines 21918 21668 -250
Branches 7374 8124 +750
==========================================
+ Hits 7272 6031 -1241- Misses 14646 15637 +991- Partials 661 536 -125Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
May 7, 2026 10:56
alexander-alderman-webb
approved these changes
May 7, 2026
alexander-alderman-webb
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I didn't know we had so many feature flag integrations
Uh oh!
There was an error while loading. Please reload this page.
cla7aye15I4nd pushed a commit
to cla7aye15I4nd/sentry-python
that referenced
this pull request
May 7, 2026
### Description
Set
[`flag.evaluation.{key}`](https://getsentry.github.io/sentry-conventions/attributes/flag/#flag-evaluation-key)
as span attribute in span streaming mode.
Add a span streaming test variant to affected integrations:
- Unleash
- Statsig
- Launchdarkly
- OpenFeature
#### Issues
- Closes
https://linear.app/getsentry/issue/PY-2141/support-feature-flags-in-span-first
- Closesgetsentry#5676
- Closes
https://linear.app/getsentry/issue/PY-2372/migrate-unleash-to-span-first
- Closesgetsentry#6070
- Closes
https://linear.app/getsentry/issue/PY-2364/migrate-statsig-to-span-first
- Closesgetsentry#6062
- Closes
https://linear.app/getsentry/issue/PY-2335/migrate-launchdarkly-to-span-first
- Closesgetsentry#6033
- Closes
https://linear.app/getsentry/issue/PY-2344/migrate-openfeature-to-span-first
- Closesgetsentry#6042
#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)mgaligniana pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
### Description
Set
[`flag.evaluation.{key}`](https://getsentry.github.io/sentry-conventions/attributes/flag/#flag-evaluation-key)
as span attribute in span streaming mode.
Add a span streaming test variant to affected integrations:
- Unleash
- Statsig
- Launchdarkly
- OpenFeature
#### Issues
- Closes
https://linear.app/getsentry/issue/PY-2141/support-feature-flags-in-span-first
- Closesgetsentry#5676
- Closes
https://linear.app/getsentry/issue/PY-2372/migrate-unleash-to-span-first
- Closesgetsentry#6070
- Closes
https://linear.app/getsentry/issue/PY-2364/migrate-statsig-to-span-first
- Closesgetsentry#6062
- Closes
https://linear.app/getsentry/issue/PY-2335/migrate-launchdarkly-to-span-first
- Closesgetsentry#6033
- Closes
https://linear.app/getsentry/issue/PY-2344/migrate-openfeature-to-span-first
- Closesgetsentry#6042
#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
flag.evaluation.{key}as span attribute in span streaming mode.Add a span streaming test variant to affected integrations:
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)