feat(pymongo): Add span streaming support by ericapisani · Pull Request #6253 · getsentry/sentry-python

ericapisani · 2026-05-11T17:52:28Z

Add span streaming support to the PyMongo integration. The legacy code path is preserved unchanged for non-streaming clients.

Fixes PY-2349
Fixes#6047

Add span streaming support to the PyMongo integration, mirroring the pattern used in the asyncpg integration. When trace_lifecycle=stream is enabled, spans are emitted using the new StreamedSpan API with OTel-style attributes. The legacy code path is preserved for non-streaming clients. Fixes PY-2349 Fixes#6047

linear-code · 2026-05-11T17:52:33Z

PY-2349

ericapisani · 2026-05-11T17:53:18Z

bugbot run

ericapisani · 2026-05-11T17:53:23Z

@sentry review

github-actions · 2026-05-11T17:54:18Z

Codecov Results 📊

✅ 146 passed | Total: 146 | Pass Rate: 100% | Execution Time: 22.83s

📊 Comparison with Base Branch

Metric	Change
Total Tests	—
Passed Tests	—
Failed Tests	—
Skipped Tests	—

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 5.36%. Project has 14368 uncovered lines.
✅ Project coverage is 34.92%. Comparing base (base) to head (head).

Files with missing lines (1)

File	Patch %	Lines
`pymongo.py`	9.79%	⚠️ 129 Missing

Coverage diff

@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 30.12% 34.92% +4.8%
==========================================
Files 190 190 —
Lines 21907 22079 +172
Branches 7818 7424 -394
==========================================
+ Hits 6598 7711 +1113- Misses 15309 14368 -941- Partials 695 807 +112

Generated by Codecov Action

ericapisani · 2026-05-11T18:19:38Z

+
+ data: "Dict[str, Any]" = {"operation_ids": {}}
+ data["operation_ids"]["operation"] = event.operation_id
+ data["operation_ids"]["request"] = event.request_id


These are also kept for legacy reasons, are being removed for streamed spans.

sentrivana

Looking good, but we're using some deprecated attributes here, I've highlighted the ones I noticed but please have another look at the rest we're setting on the span first path as well 🙏🏻 Approving to not block.

sentrivana · 2026-05-12T09:09:19Z

+ if type(span) is StreamedSpan:
+ span.status = SpanStatus.OK


OK is the default value for StreamedSpans, so technically we don't need to set it here

sentrivana · 2026-05-12T09:12:10Z

IIRC this is deprecated and superseded by SPANDATA.DB_NAMESPACE, so we should use that in span first

sentrivana · 2026-05-12T09:14:03Z

+ "db.name": event.database_name,
+ SPANDATA.DB_SYSTEM: "mongodb",
+ SPANDATA.DB_DRIVER_NAME: "pymongo",
+ SPANDATA.DB_OPERATION: event.command_name,


Suggested change
SPANDATA.DB_OPERATION: event.command_name,
SPANDATA.DB_OPERATION_NAME: event.command_name,
https://getsentry.github.io/sentry-conventions/attributes/db/#db-operation

sentrivana · 2026-05-12T09:14:43Z

+ if has_span_streaming_enabled(client.options):
+ span_first_data = {
+ "db.name": event.database_name,
+ SPANDATA.DB_SYSTEM: "mongodb",


Suggested change
SPANDATA.DB_SYSTEM: "mongodb",
SPANDATA.DB_SYSTEM_NAME: "mongodb",

sentrivana · 2026-05-12T09:27:45Z



+@pytest.mark.parametrize("with_pii", [False, True])
+def test_transactions_span_streaming(


Would be good to not use the term transaction in the span streaming tests as there are no transactions anymore. Maybe just span or segment if we want to emphasize that a span is root-level.
Looks like we're mentioning transactions in this test name and then also when we're creating spans by hand in this test and others we're calling them test_transaction

sentry · 2026-05-12T15:11:20Z

- if db_name is not None:
- data[SPANDATA.DB_NAME] = db_name

 server_address = event.connection_id[0]


Bug: Accessing a non-indexable event.connection_id in _get_db_data raises a TypeError that is silently caught, causing the entire pymongo span to be dropped.
_{Severity: MEDIUM}
Suggested Fix
Wrap the access to event.connection_id within a try...except TypeError block. This will prevent the unhandled exception from halting execution, allowing the span to be created even if peer address data cannot be extracted.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: sentry_sdk/integrations/pymongo.py#L98 Potential issue: The function `_get_db_data` directly accesses `event.connection_id` to retrieve database connection details. If `event.connection_id` is not an indexable type (e.g., an integer), a `TypeError` is raised. This exception is caught and suppressed by the `capture_internal_exceptions` context manager, which then prematurely exits the `with` block. As a consequence, the associated Sentry span is never created, and the entire pymongo event is silently dropped. This is a regression from previous behavior where this error was handled, and a span was still created.
_{Did we get this right? 👍 / 👎 to inform future reviews.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 30ba6da. Configure here.}

Add span streaming support to the PyMongo integration. The legacy code path is preserved unchanged for non-streaming clients. Fixes PY-2349 Fixesgetsentry#6047

ericapisani added the skip-changelog label May 11, 2026

cursorBot reviewed May 11, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/pymongo.py

Address bugbot comment
67383b2

ericapisani commented May 11, 2026
View reviewed changes

Fix error
eb4a7bd

ericapisani marked this pull request as ready for review May 11, 2026 18:46

ericapisani requested a review from a team as a code owner May 11, 2026 18:46

sentrivana approved these changes May 12, 2026
View reviewed changes

sentrivana reviewed May 12, 2026
View reviewed changes

Address PR comments
04bf803

sentryBot reviewed May 12, 2026
View reviewed changes

cursorBot reviewed May 12, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/pymongo.py Outdated
Comment threadsentry_sdk/integrations/pymongo.py

address bot comments
30ba6da

cursorBot reviewed May 12, 2026
View reviewed changes

Comment threadsentry_sdk/integrations/pymongo.py

ericapisani merged commit edaa6d6 into masterMay 12, 2026
156 checks passed

ericapisani deleted the py-2349-migrate-pymongo branch May 12, 2026 16:05

	SPANDATA.DB_OPERATION: event.command_name,
	SPANDATA.DB_OPERATION_NAME: event.command_name,

	SPANDATA.DB_SYSTEM: "mongodb",
	SPANDATA.DB_SYSTEM_NAME: "mongodb",



		@pytest.mark.parametrize("with_pii", [False, True])
		def test_transactions_span_streaming(

Uh oh!

Conversation

ericapisani commented May 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-codeBot commented May 11, 2026

Uh oh!

ericapisani commented May 11, 2026

Uh oh!

ericapisani commented May 11, 2026

Uh oh!

github-actionsBot commented May 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

Uh oh!

Uh oh!

ericapisaniMay 11, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

sentrivanaMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivanaMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivanaMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivanaMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

sentrivanaMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

sentryBotMay 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ericapisani commented May 11, 2026•
edited
Loading

github-actionsBot commented May 11, 2026•
edited
Loading