test(flask): Add span streaming test coverage - #6264

Merged

ericapisani merged 10 commits into

py-2323-migrate-flask

May 19, 2026

ericapisani commented May 13, 2026•
edited
Loading

Member

Add test coverage to ensure that span streaming works for Flask. No additional changes are needed because we are no longer adding the request body to the streamed spans, and span streaming support has been added earlier to the uWSGI middleware which the Flask integration leverages.

Fixes PY-2323
Fixes#6021

feat(flask): Add span streaming support and request body capture

c74acb1

Add request body data to the streaming segment span when span streaming is enabled. Update existing tests to cover both streaming and non-streaming code paths, and add new tests for request body capture, size limits, and header scrubbing in streaming mode.
Fixes PY-2323
Fixes#6021

linear-codeBot commented May 13, 2026

ericapisani commented May 13, 2026

MemberAuthor

bugbot run

ericapisani commented May 13, 2026

MemberAuthor

@sentry review

github-actionsBot commented May 13, 2026•
edited
Loading

Contributor

Codecov Results 📊

✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 42.54s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14867 uncovered lines.

Files with missing lines (1)

File	Patch %	Lines
`flask.py`	12.50%	⚠️ 112 Missing

Generated by Codecov Action

sentryBot reviewed

View reviewed changes

sentry_sdk/integrations/flask.py Outdated

cursorBot reviewed

View reviewed changes

sentry_sdk/integrations/flask.py Outdated

move common function between flask and starlette to more central place

c557b26

ericapisani commented

View reviewed changes

sentry_sdk/integrations/flask.py Outdated

ericapisani marked this pull request as ready for review

May 14, 2026 13:55

ericapisani requested a review from a team as a code owner

May 14, 2026 13:55

add comment back in that was accidentally removed, small cleanups

2df2cd3

alexander-alderman-webb requested changes

View reviewed changes

alexander-alderman-webb left a comment

Contributor

I just looked at the request body attribute since I'm solving this in Starlette right now, and the same problem applies here 😅

sentry_sdk/integrations/flask.py Outdated

ericapisani added 2 commits

May 15, 2026 09:52

Read the request body before sending the response to the user instead…

c90dc55

… of just as the request is getting started

Merge branch 'master' into py-2323-migrate-flask

984a63a

ericapisani marked this pull request as draft

May 15, 2026 13:57

cursorBot reviewed

View reviewed changes

sentry_sdk/integrations/flask.py Outdated

Improve handling of situation where a request body is never read in t…

b7c0ec6

…he handler

ericapisani commented May 15, 2026

MemberAuthor

bugbot run
@sentry review

cursorBot reviewed

View reviewed changes

cursorBot left a comment

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit b7c0ec6. Configure here.}

sentry-wardenBot reviewed

View reviewed changes

sentry_sdk/integrations/_wsgi_common.py Outdated

sentry-wardenBot reviewed

View reviewed changes

sentry_sdk/integrations/flask.py

ericapisani added 3 commits

May 15, 2026 12:51

fix for unbounded consumption of request wtihout a content-header spe…

3b71c16

…cified

Merge branch 'master' into py-2323-migrate-flask

234e667

Revert changes as they were centred around adding the request body, w…

8b28bef

…hich we are no longer doing. Add test coverage to ensure span streaming is working as expected

ericapisani changed the title ~~feat(flask): Add span streaming support and request body capture~~test(flask): Add span streaming test coverage

ericapisani marked this pull request as ready for review

May 19, 2026 13:02

alexander-alderman-webb approved these changes

View reviewed changes

alexander-alderman-webb commented May 19, 2026

Contributor

The tests seem to fail; feel free to merge after fixing them if it's a trivial problem.

sentry-wardenBot reviewed

View reviewed changes

tests/integrations/flask/test_flask.py

remove assertion as its failure is due to testing conditions - in pro…

855a9bb

…duction it would be set

ericapisani enabled auto-merge (squash)

May 19, 2026 14:14

ericapisani merged commit ccf8f09 into master

157 checks passed

ericapisani deleted the py-2323-migrate-flask branch

May 19, 2026 14:14

sentry-release-botBot mentioned this pull request

publish: getsentry/sentry-python@2.61.0 getsentry/publish#8297

Closed

6 tasks

mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request

test(flask): Add span streaming test coverage (getsentry#6264)

59c1427

Add test coverage to ensure that span streaming works for Flask. No
additional changes are needed because we are no longer adding the
request body to the streamed spans, and span streaming support has been
added earlier to the uWSGI middleware which the Flask integration
leverages.
Fixes PY-2323
Fixesgetsentry#6021

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet