Skip to content

feat(starlite): Support span streaming - #6294

Merged
sl0thentr0py merged 2 commits into
masterfrom
neel/span-first/starlite
May 19, 2026
Merged

feat(starlite): Support span streaming#6294
sl0thentr0py merged 2 commits into
masterfrom
neel/span-first/starlite

Conversation

@sl0thentr0py

Copy link
Copy Markdown
Member

No description provided.

@sl0thentr0py
sl0thentr0py requested a review from a team as a code ownerMay 19, 2026 12:47
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/starlite branch from dc0e24b to a5d33e6CompareMay 19, 2026 12:47
@github-actions

github-actionsBot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

59 passed | Total: 59 | Pass Rate: 100% | Execution Time: 25.30s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 20.00%. Project has 16258 uncovered lines.
✅ Project coverage is 27.27%. Comparing base (base) to head (head).

Files with missing lines (2)
FilePatch %Lines
starlite.py9.09%⚠️ 140 Missing
consts.py99.50%⚠️ 2 Missing
Coverage diff
@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 27.27% 27.27% —%
==========================================
Files 190 190 —
Lines 22328 22353 +25
Branches 7576 7584 +8
==========================================
+ Hits 6088 6095 +7- Misses 16240 16258 +18- Partials 545 545 —

Generated by Codecov Action

Comment threadtests/integrations/starlite/test_starlite.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/starlite branch from a5d33e6 to f0514b6CompareMay 19, 2026 13:01

@sentrivanasentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One attr name, looks good otherwise

Comment threadsentry_sdk/integrations/starlite.py Outdated
attributes={
"sentry.op": op,
"sentry.origin": StarliteIntegration.origin,
"starlite.middleware_name": middleware_name,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"starlite.middleware_name": middleware_name,
"middleware.name": middleware_name,

https://getsentry.github.io/sentry-conventions/attributes/middleware/#middleware-name

@sl0thentr0py
sl0thentr0py enabled auto-merge (squash) May 19, 2026 13:19
@sl0thentr0py
sl0thentr0py merged commit 75aaebf into masterMay 19, 2026
157 checks passed
@sl0thentr0py
sl0thentr0py deleted the neel/span-first/starlite branch May 19, 2026 13:33
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sl0thentr0py@sentrivana