Uh oh!
There was an error while loading. Please reload this page.
ref(wsgi): Remove unused segment name setting - #6305
Conversation
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.59s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14885 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 33.42% 33.43% +0.01%
==========================================
Files 190 190 —
Lines 22366 22360 -6
Branches 7594 7588 -6
==========================================
+ Hits 7475 7475 —- Misses 14891 14885 -6- Partials 744 744 —Generated by Codecov Action |
Codecov Results 📊✅ 5 passed | Total: 5 | Pass Rate: 100% | Execution Time: 810ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 17191 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 23.32% 23.12% -0.2%
==========================================
Files 190 190 —
Lines 22366 22360 -6
Branches 7594 7588 -6
==========================================
+ Hits 5216 5169 -47- Misses 17150 17191 +41- Partials 479 476 -3Generated by Codecov Action |
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Perfect makes the Django migration simpler 🙏
I'll wait to merge mine after this is in
Uh oh!
There was an error while loading. Please reload this page.
### Description In span first, there is logic in the WSGI integration that sets the segment name and the source attribute to a generic default at the end of a segment span's lifecycle, unless the name/source have been set explicitly. This logic is unnecessary. We create the segment with the default name and source, so there's no reason to rename again at the end. If the segment was renamed during its lifetime, that's the name we want to keep; the default is just a fallback. #### Issues <!-- * resolves: getsentry#1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
Description
In span first, there is logic in the WSGI integration that sets the segment name and the source attribute to a generic default at the end of a segment span's lifecycle, unless the name/source have been set explicitly.
This logic is unnecessary. We create the segment with the default name and source, so there's no reason to rename again at the end. If the segment was renamed during its lifetime, that's the name we want to keep; the default is just a fallback.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)