Skip to content

feat(sanic): Support span streaming - #6319

Merged
sl0thentr0py merged 3 commits into
masterfrom
neel/span-first/sanic
May 26, 2026
Merged

feat(sanic): Support span streaming#6319
sl0thentr0py merged 3 commits into
masterfrom
neel/span-first/sanic

Conversation

@sl0thentr0py

@sl0thentr0pysl0thentr0py commented May 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The _unsampled_statuses option is not respected for span streaming since we currently don't allow tail-based sampling in the new system.

Issues

@sl0thentr0py
sl0thentr0py requested a review from a team as a code ownerMay 21, 2026 12:56
@linear-code

linear-codeBot commented May 21, 2026

Copy link
Copy Markdown

PY-2357

@github-actions

github-actionsBot commented May 21, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 67 passed | Total: 67 | Pass Rate: 100% | Execution Time: 6.14s

📊 Comparison with Base Branch

MetricChange
Total Tests—
Passed Tests—
Failed Tests—
Skipped Tests—

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 9.52%. Project has 14506 uncovered lines.
✅ Project coverage is 35.68%. Comparing base (base) to head (head).

Files with missing lines (1)
FilePatch %Lines
sanic.py9.35%⚠️ 194 Missing
Coverage diff
@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 35.03% 35.68% +0.65%
==========================================
Files 190 190 —
Lines 22647 22553 -94
Branches 7722 8157 +435
==========================================
+ Hits 7934 8047 +113- Misses 14713 14506 -207- Partials 718 712 -6

Generated by Codecov Action

@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch from d266281 to 950a311CompareMay 21, 2026 13:00
sentry-warden[bot]
sentry-wardenBot reviewed May 21, 2026
View reviewed changes
Comment threadtests/integrations/sanic/test_sanic.py
sentry-warden[bot]
sentry-wardenBot reviewed May 21, 2026
View reviewed changes
Comment threadsentry_sdk/integrations/sanic.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch 2 times, most recently from ca346f8 to d10461bCompareMay 21, 2026 13:27
cursor[bot]
cursorBot reviewed May 21, 2026
View reviewed changes
Comment threadsentry_sdk/integrations/sanic.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch from d10461b to 9e8d40bCompareMay 21, 2026 13:48
sentry-warden[bot]
sentry-wardenBot reviewed May 21, 2026
View reviewed changes
Comment threadsentry_sdk/traces.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch 2 times, most recently from e9d3bf6 to 0f32453CompareMay 21, 2026 14:16
ericapisani
ericapisani reviewed May 21, 2026
View reviewed changes

@ericapisaniericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things but otherwise LGTM. Approving so as not to block it from merging

Comment threadsentry_sdk/integrations/sanic.py Outdated
Comment threadsentry_sdk/integrations/sanic.py
Comment threadtests/integrations/sanic/test_sanic.py Outdated
sentrivana
sentrivana reviewed May 22, 2026
View reviewed changes
Comment threadsentry_sdk/integrations/sanic.py Outdated
sentrivana
sentrivana approved these changes May 22, 2026
View reviewed changes

@sentrivanasentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple small things _end -> end and TransactionSource -> SegmentSource

Comment threadsentry_sdk/integrations/sanic.py
with capture_internal_exceptions():
scope = sentry_sdk.get_current_scope()
route_name = route.name.replace(request.app.name, "").strip(".")
scope.set_transaction_name(route_name, source=TransactionSource.COMPONENT)

@sentrivanasentrivanaMay 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a SegmentSource too for the streaming path. Would be good to use that if span streaming is enabled

@sl0thentr0pysl0thentr0pyMay 26, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the method itself is called set_transaction_name. If we want to clean this up properly, we should make a segment based method, just switching the source is half-assed

@sl0thentr0pysl0thentr0pyMay 26, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now, let's clean this up separately all together

Comment threadsentry_sdk/integrations/sanic.py
sanic_route = sanic_route[len(sanic_app_name) + 1 :]

scope.set_transaction_name(
sanic_route, source=TransactionSource.COMPONENT

@sentrivanasentrivanaMay 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too we should do SegmentSource if streaming

Comment threadsentry_sdk/integrations/sanic.py
)
else:
scope.set_transaction_name(
rv[0].__name__, source=TransactionSource.COMPONENT

@sentrivanasentrivanaMay 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

sentrivana
sentrivana reviewed May 22, 2026
View reviewed changes
Comment threadtests/integrations/sanic/test_sanic.py Outdated
sentrivana
sentrivana reviewed May 22, 2026
View reviewed changes
Comment threadtests/integrations/sanic/test_sanic.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch from 0f32453 to 6748b61CompareMay 26, 2026 11:36
cursor[bot]
cursorBot reviewed May 26, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6748b61. Configure here.

Comment threadsentry_sdk/integrations/sanic.py Outdated
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch from 7e2267f to cb11ab0CompareMay 26, 2026 12:23
@sl0thentr0py
feat(sanic): Support span streaming
5daee33
The `_unsampled_statuses` option is not respected for span streaming
since we currently don't allow tail-based sampling in the new system.
@sl0thentr0py
PR fixes
ee72941
@sl0thentr0py
trigger
58850a3
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/span-first/sanic branch from 0a35b9d to 58850a3CompareMay 26, 2026 13:58
@sl0thentr0py
sl0thentr0py enabled auto-merge (squash) May 26, 2026 13:58
@sl0thentr0py
sl0thentr0py merged commit fdeb78e into masterMay 26, 2026
157 checks passed
@sl0thentr0py
sl0thentr0py deleted the neel/span-first/sanic branch May 26, 2026 14:13
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Merged
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
@sl0thentr0py@mgaligniana
feat(sanic): Support span streaming (getsentry#6319)
2a9a16f
The `_unsampled_statuses` option is not respected for span streaming
since we currently don't allow tail-based sampling in the new system.
#### Issues
* resolves: getsentry#6055
* resolves: PY-2357
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericapisaniericapisaniericapisani left review comments
@sentrivanasentrivanasentrivana approved these changes
@cursorcursor[bot]cursor[bot] left review comments
@alexander-alderman-webbalexander-alderman-webbalexander-alderman-webb left review comments
@sentry-wardensentry-warden[bot]sentry-warden[bot] left review comments

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate sanic to span first

4 participants

@sl0thentr0py@ericapisani@sentrivana@alexander-alderman-webb