Skip to content

test(openai-agents): Deduplicate by removing node.callspec.id matching - #6424

Merged
alexander-alderman-webb merged 2 commits into
masterfrom
webb/openai-agents/remove-node-callspec
May 27, 2026
Merged

test(openai-agents): Deduplicate by removing node.callspec.id matching#6424
alexander-alderman-webb merged 2 commits into
masterfrom
webb/openai-agents/remove-node-callspec

Conversation

@alexander-alderman-webb

@alexander-alderman-webbalexander-alderman-webb commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

Jointly parametrize on instructions, input and the expected value of the gen_ai.system_instructions and gen_ai.request.messages attributes

Only keep one test case for None system instructions.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review May 27, 2026 07:26
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code ownerMay 27, 2026 07:26
@github-actions

github-actionsBot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.74s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14769 uncovered lines.
✅ Project coverage is 34.91%. Comparing base (base) to head (head).

Coverage diff
@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 34.91% 34.91% —%
==========================================
Files 190 190 —
Lines 22689 22689 —
Branches 7742 7742 —
==========================================
+ Hits 7920 7920 —- Misses 14769 14769 —- Partials 832 832 —

Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

7 passed | Total: 7 | Pass Rate: 100% | Execution Time: 3.60s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 17021 uncovered lines.


Generated by Codecov Action

@alexander-alderman-webbalexander-alderman-webb changed the title test(openai-agents): Deduplicate in tests by removing node.callspec.id matchingtest(openai-agents): Deduplicate by removing node.callspec.id matchingMay 27, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit 8b732bf into masterMay 27, 2026
148 of 151 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/openai-agents/remove-node-callspec branch May 27, 2026 14:14
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-alderman-webb@sentrivana