Uh oh!
There was an error while loading. Please reload this page.
feat(bottle): Add span streaming support to Bottle integration - #6486
Conversation
Fixes PY-2310 Fixes#6008
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Results 📊✅ 88426 passed | ⏭️ 6022 skipped | Total: 94448 | Pass Rate: 93.62% | Execution Time: 294m 8s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 85.71%. Project has 2473 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
+ Coverage 89.35% 89.38% +0.03%
==========================================
Files 192 192 —
Lines 23273 23285 +12
Branches 7998 8002 +4
==========================================
+ Hits 20794 20812 +18- Misses 2479 2473 -6- Partials 1309 1308 -1Generated by Codecov Action |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sentrivana
left a comment
There was a problem hiding this comment.
One small suggestion, but lgtm!
| res = old_handle(self, environ) | ||
| if has_span_streaming_enabled(sentry_sdk.get_client().options): | ||
| res = old_handle(self, environ) |
There was a problem hiding this comment.
Looks like we can take this line out of the condition bodies since it's the same for both branches
There was a problem hiding this comment.
Good eye, will make that fix!
…python into py-2310-migrate-bottle
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5753f41. Configure here.
| if has_span_streaming_enabled(sentry_sdk.get_client().options): | ||
| _set_segment_name_and_source( | ||
| transaction_style=integration.transaction_style | ||
| ) |
There was a problem hiding this comment.
Post-handle naming can fail requests
Medium Severity
After a successful old_handle, span-streaming runs _set_segment_name_and_source on the critical response path. That helper only catches RuntimeError, and the call is not wrapped in capture_internal_exceptions. Any other exception while reading bottle_request.route or calling set_transaction_name can abort the request after the handler already returned a response.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5753f41. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
…ntry#6486) Add span streaming support to Bottle integration. Fixes PY-2310 Fixesgetsentry#6008


Add span streaming support to Bottle integration.
Fixes PY-2310
Fixes#6008