Uh oh!
There was an error while loading. Please reload this page.
ref: Stop returning StreamedSpan from get_start_span_function() - #6560
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Codecov Results 📊✅ 89411 passed | ⏭️ 6013 skipped | Total: 95424 | Pass Rate: 93.7% | Execution Time: 304m 6s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2397 uncovered lines. Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 89.81% 89.78% -0.03%
==========================================
Files 192 192 —
Lines 23460 23455 -5
Branches 8062 8058 -4
==========================================
+ Hits 21069 21058 -11- Misses 2391 2397 +6- Partials 1328 1328 —Generated by Codecov Action |
| if has_span_streaming_enabled(sentry_sdk.get_client().options): | ||
| return sentry_sdk.traces.start_span |
There was a problem hiding this comment.
Don't we still need this part? Without it we're only using non-streaming APIs in this function
There was a problem hiding this comment.
Or are we simply not using the helper in a streaming context anymore?
There was a problem hiding this comment.
Yes the plan is to drop the wrapper in span streaming branches.
And after #6404 is merged it won't be used when span streaming is enabled.
Uh oh!
There was an error while loading. Please reload this page.
…etsentry#6560) The new `traces.start_span()` API automatically promotes spans to segment spans if there is no active segment. Since `get_start_span_function()` is never invoked when span streaming is enabled, the function does not need to support the streaming trace lifecycle.
Description
The new
start_span()API automatically promotes spans to segment spans if applicable.There is no need for
get_start_span_function()anymore.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)