Skip to content

feat(falcon): Set name and source on request span when streaming - #6562

Merged
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name
Jun 16, 2026
Merged

feat(falcon): Set name and source on request span when streaming#6562
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name

Conversation

@alexander-alderman-webb

@alexander-alderman-webbalexander-alderman-webb commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Call Scope.set_transaction_name() on the current scope in process_resource() to change the name and source of the segment span when span streaming is enabled.

Issues

Closes#6019

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review June 12, 2026 08:18
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code ownerJune 12, 2026 08:18

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0c17904. Configure here.

Comment threadsentry_sdk/integrations/falcon.py Outdated
@github-actions

github-actionsBot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90848 passed | ⏭️ 6037 skipped | Total: 96885 | Pass Rate: 93.77% | Execution Time: 321m 10s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2421 uncovered lines.
❌ Project coverage is 89.75%. Comparing base (base) to head (head).

Coverage diff
@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 89.78% 89.75% -0.03%
==========================================
Files 192 192 —
Lines 23620 23630 +10
Branches 8132 8134 +2
==========================================
+ Hits 21206 21209 +3- Misses 2414 2421 +7- Partials 1340 1340 —

Generated by Codecov Action

Comment threadsentry_sdk/integrations/falcon.py Outdated

@ericapisaniericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise LGTM

Comment threadsentry_sdk/integrations/falcon.py Outdated
Base automatically changed from webb/falcon/span-first to masterJune 16, 2026 06:44
@alexander-alderman-webb
alexander-alderman-webb enabled auto-merge (squash) June 16, 2026 06:58
@alexander-alderman-webb
alexander-alderman-webb merged commit 1df9835 into masterJun 16, 2026
144 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/falcon/txn-name branch June 16, 2026 07:12
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
…sentry#6562)
Call `Scope.set_transaction_name()` on the current scope in a `process_resource` middleware function (since the route is resolved when `process_resource` runs).
This ensures that the span name and the `sentry.span.source` attribute are set on the segment span when the streaming trace lifecycle is enabled.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate falcon to span first

2 participants

@alexander-alderman-webb@ericapisani