Uh oh!
There was an error while loading. Please reload this page.
feat(falcon): Set name and source on request span when streaming - #6562
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c17904. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Results 📊✅ 90848 passed | ⏭️ 6037 skipped | Total: 96885 | Pass Rate: 93.77% | Execution Time: 321m 10s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2421 uncovered lines. Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 89.78% 89.75% -0.03%
==========================================
Files 192 192 —
Lines 23620 23630 +10
Branches 8132 8134 +2
==========================================
+ Hits 21206 21209 +3- Misses 2414 2421 +7- Partials 1340 1340 —Generated by Codecov Action |
Uh oh!
There was an error while loading. Please reload this page.
ericapisani
left a comment
There was a problem hiding this comment.
One question, but otherwise LGTM
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…sentry#6562) Call `Scope.set_transaction_name()` on the current scope in a `process_resource` middleware function (since the route is resolved when `process_resource` runs). This ensures that the span name and the `sentry.span.source` attribute are set on the segment span when the streaming trace lifecycle is enabled.

Description
Call
Scope.set_transaction_name()on the current scope inprocess_resource()to change the name and source of the segment span when span streaming is enabled.Issues
Closes#6019
Reminders
uv run ruff.feat:,fix:,ref:,meta:)