Skip to content

feat(internal): Add routing instrumentations report in integrations - #2798

Merged
krystofwoldrich merged 7 commits into
5.0.0from
report-top-level-integrations
Feb 6, 2023
Merged

feat(internal): Add routing instrumentations report in integrations#2798
krystofwoldrich merged 7 commits into
5.0.0from
report-top-level-integrations

Conversation

@krystofwoldrich

@krystofwoldrichkrystofwoldrich commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

closes: #2210

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions

github-actionsBot commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4a972da

@krystofwoldrichkrystofwoldrich mentioned this pull request Feb 1, 2023
Merged
@github-actions

github-actionsBot commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time361.42 ms389.50 ms28.08 ms
Size17.73 MiB20.03 MiB2.30 MiB

Baseline results on branch: 5.0.0

Startup times

RevisionPlainWith SentryDiff
b868b53+dirty339.52 ms369.84 ms30.32 ms
d091239+dirty425.61 ms447.11 ms21.50 ms

App size

RevisionPlainWith SentryDiff
b868b53+dirty17.73 MiB19.95 MiB2.22 MiB
d091239+dirty17.73 MiB19.95 MiB2.22 MiB

@github-actions

github-actionsBot commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1239.98 ms1256.46 ms16.48 ms
Size2.36 MiB2.81 MiB461.96 KiB

Baseline results on branch: 5.0.0

Startup times

RevisionPlainWith SentryDiff
b868b53+dirty1274.90 ms1305.68 ms30.78 ms
d091239+dirty1251.49 ms1276.75 ms25.26 ms

App size

RevisionPlainWith SentryDiff
b868b53+dirty2.36 MiB2.74 MiB384.64 KiB
d091239+dirty2.36 MiB2.74 MiB384.64 KiB

@github-actions

github-actionsBot commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time261.38 ms302.76 ms41.38 ms
Size7.15 MiB8.08 MiB956.12 KiB

Baseline results on branch: 5.0.0

Startup times

RevisionPlainWith SentryDiff
b868b53+dirty321.42 ms342.74 ms21.32 ms
d091239+dirty340.16 ms366.42 ms26.26 ms

App size

RevisionPlainWith SentryDiff
b868b53+dirty7.15 MiB8.00 MiB874.27 KiB
d091239+dirty7.15 MiB8.00 MiB874.38 KiB

marandaneto
marandaneto reviewed Feb 1, 2023
View reviewed changes
Comment threadsrc/js/tracing/routingInstrumentation.ts
@marandaneto

marandaneto commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Can we also do that for other features that require a setup, such as https://docs.sentry.io/platforms/react-native/touchevents/ and https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/#react-profiler

@github-actions

github-actionsBot commented Feb 2, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1282.16 ms1284.54 ms2.38 ms
Size2.92 MiB3.37 MiB462.98 KiB

Baseline results on branch: 5.0.0

Startup times

RevisionPlainWith SentryDiff
b868b53+dirty1253.68 ms1253.94 ms0.26 ms
d091239+dirty1261.62 ms1275.80 ms14.17 ms

App size

RevisionPlainWith SentryDiff
b868b53+dirty2.92 MiB3.30 MiB387.19 KiB
d091239+dirty2.92 MiB3.30 MiB387.22 KiB

@krystofwoldrich
krystofwoldrich marked this pull request as ready for review February 3, 2023 11:20
marandaneto
marandaneto reviewed Feb 3, 2023
View reviewed changes
Comment threadsrc/js/touchevents.tsx
marandaneto
marandaneto approved these changes Feb 3, 2023
View reviewed changes

@marandanetomarandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a last comment otherwise LGTM

@krystofwoldrich
krystofwoldrich merged commit e135fed into 5.0.0Feb 6, 2023
@krystofwoldrich
krystofwoldrich deleted the report-top-level-integrations branch February 6, 2023 10:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@marandanetomarandanetomarandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krystofwoldrich@marandaneto