Skip to content

fix(sdk): Rename app start measurements to match other SDKs - #2855

Merged
krystofwoldrich merged 7 commits into
mainfrom
kw-fix-app-start-measurements-naming
Mar 2, 2023
Merged

fix(sdk): Rename app start measurements to match other SDKs#2855
krystofwoldrich merged 7 commits into
mainfrom
kw-fix-app-start-measurements-naming

Conversation

@krystofwoldrich

@krystofwoldrichkrystofwoldrich commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Renames the app start measurement to app_start_warm and keeps the op as app.start.warm to be aligned with the other mobile SDK.

💡 Motivation and Context

Although the mentioned issue is closed and the main cause of the long app start time was resolved in

I believe users are seeing app start times only till sdk version 4.5.0

as the measurement was renamed from app_start_warm to app.start.warm.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrichkrystofwoldrich added the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Feb 24, 2023
@github-actions

github-actionsBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time336.06 ms346.94 ms10.88 ms
Size17.73 MiB20.04 MiB2.31 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d197b5c+dirty338.94 ms354.87 ms15.93 ms
9a3ca65+dirty326.93 ms330.14 ms3.21 ms
86d6d2c+dirty332.90 ms352.45 ms19.55 ms

App size

RevisionPlainWith SentryDiff
d197b5c+dirty17.73 MiB20.04 MiB2.31 MiB
9a3ca65+dirty17.73 MiB20.04 MiB2.31 MiB
86d6d2c+dirty17.73 MiB20.04 MiB2.31 MiB

Previous results on branch: kw-fix-app-start-measurements-naming

Startup times

RevisionPlainWith SentryDiff
d7898dc+dirty346.04 ms355.96 ms9.92 ms

App size

RevisionPlainWith SentryDiff
d7898dc+dirty17.73 MiB20.04 MiB2.31 MiB

@github-actions

github-actionsBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1244.60 ms1255.46 ms10.86 ms
Size2.36 MiB2.82 MiB469.43 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d197b5c+dirty1217.61 ms1242.66 ms25.05 ms
9a3ca65+dirty1247.06 ms1274.58 ms27.52 ms
86d6d2c+dirty1267.55 ms1286.21 ms18.66 ms

App size

RevisionPlainWith SentryDiff
d197b5c+dirty2.36 MiB2.82 MiB462.86 KiB
9a3ca65+dirty2.36 MiB2.82 MiB462.89 KiB
86d6d2c+dirty2.36 MiB2.82 MiB462.82 KiB

Previous results on branch: kw-fix-app-start-measurements-naming

Startup times

RevisionPlainWith SentryDiff
d7898dc+dirty1228.84 ms1240.08 ms11.24 ms

App size

RevisionPlainWith SentryDiff
d7898dc+dirty2.36 MiB2.82 MiB463.19 KiB

@github-actions

github-actionsBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1270.10 ms1280.12 ms10.02 ms
Size2.92 MiB3.37 MiB464.62 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d197b5c+dirty1234.80 ms1249.20 ms14.40 ms
9a3ca65+dirty1276.40 ms1279.14 ms2.74 ms
86d6d2c+dirty1291.62 ms1296.80 ms5.18 ms

App size

RevisionPlainWith SentryDiff
d197b5c+dirty2.92 MiB3.37 MiB464.41 KiB
9a3ca65+dirty2.92 MiB3.37 MiB464.32 KiB
86d6d2c+dirty2.92 MiB3.37 MiB464.31 KiB

Previous results on branch: kw-fix-app-start-measurements-naming

Startup times

RevisionPlainWith SentryDiff
d7898dc+dirty1279.10 ms1292.68 ms13.58 ms

App size

RevisionPlainWith SentryDiff
d7898dc+dirty2.92 MiB3.37 MiB464.62 KiB

@github-actions

github-actionsBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time294.18 ms375.98 ms81.80 ms
Size7.15 MiB8.09 MiB964.41 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d197b5c+dirty258.75 ms313.61 ms54.86 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms
86d6d2c+dirty267.21 ms325.24 ms58.04 ms

App size

RevisionPlainWith SentryDiff
d197b5c+dirty7.15 MiB8.09 MiB962.72 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB
86d6d2c+dirty7.15 MiB8.09 MiB962.69 KiB

Previous results on branch: kw-fix-app-start-measurements-naming

Startup times

RevisionPlainWith SentryDiff
d7898dc+dirty336.15 ms350.71 ms14.56 ms

App size

RevisionPlainWith SentryDiff
d7898dc+dirty7.15 MiB8.09 MiB963.36 KiB

@krystofwoldrichkrystofwoldrich removed the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Feb 27, 2023
@krystofwoldrichkrystofwoldrich mentioned this pull request Feb 27, 2023
Merged
marandaneto
marandaneto reviewed Feb 27, 2023
View reviewed changes
Comment threadtest/tracing/reactnativetracing.test.ts Outdated
@krystofwoldrichkrystofwoldrich mentioned this pull request Mar 2, 2023
Closed
11 tasks
marandaneto
marandaneto approved these changes Mar 2, 2023
View reviewed changes

@marandanetomarandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krystofwoldrich

@krystofwoldrich
krystofwoldrich enabled auto-merge (squash) March 2, 2023 10:59
@krystofwoldrich
krystofwoldrich merged commit 982b55d into mainMar 2, 2023
@krystofwoldrich
krystofwoldrich deleted the kw-fix-app-start-measurements-naming branch March 2, 2023 11:07
@fabiendem

fabiendem commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@krystofwoldrich Are you planning on shipping this in the 4.* version of the SDK?
Or should we consider 4.* as no longer maintained?

Thanks for the fix

@krystofwoldrich

krystofwoldrich commented Mar 6, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@fabiendemv4 is not actively maintained and won't get new features. It might get some critical fixes, but this likely is not one of them.

As the start-up times from the v4 can be viewed as custom measurements if your plan supports it.
https://docs.sentry.io/platforms/python/performance/instrumentation/performance-metrics/#custom-metrics

@krystofwoldrichkrystofwoldrich mentioned this pull request Jul 27, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@marandanetomarandanetomarandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krystofwoldrich@fabiendem@marandaneto