Skip to content

chore: update scripts/update-rn.sh to v0.72.0 - #3146

Merged
krystofwoldrich merged 7 commits into
mainfrom
kw-rn-upgrade-0-72
Jun 27, 2023
Merged

chore: update scripts/update-rn.sh to v0.72.0#3146
krystofwoldrich merged 7 commits into
mainfrom
kw-rn-upgrade-0-72

Conversation

@krystofwoldrich

@krystofwoldrichkrystofwoldrich commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Upgrade to the latest RN version 0.72.0

  • upgrade e2e test
  • upgrade sample app to the latest template
  • upgrade sdk dev dep

💡 Motivation and Context

💚 How did you test it?

sample app, ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jun 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time350.65 ms388.38 ms37.72 ms
Size17.73 MiB19.81 MiB2.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
70caa60+dirty299.00 ms321.02 ms22.02 ms
e2b64fe316.88 ms330.23 ms13.35 ms
9a3ca65+dirty326.93 ms330.14 ms3.21 ms
ad6c299375.94 ms382.02 ms6.08 ms
d197b5c+dirty338.94 ms354.87 ms15.93 ms
15c80ab+dirty336.27 ms350.58 ms14.31 ms
8900e1a+dirty430.68 ms456.13 ms25.44 ms
80b2ce3385.02 ms387.36 ms2.34 ms
34aba08328.10 ms342.84 ms14.74 ms
76d1baf+dirty335.72 ms355.52 ms19.80 ms

App size

RevisionPlainWith SentryDiff
70caa60+dirty17.73 MiB19.75 MiB2.01 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
9a3ca65+dirty17.73 MiB20.04 MiB2.31 MiB
ad6c29917.73 MiB19.75 MiB2.02 MiB
d197b5c+dirty17.73 MiB20.04 MiB2.31 MiB
15c80ab+dirty17.73 MiB20.04 MiB2.31 MiB
8900e1a+dirty17.73 MiB19.75 MiB2.01 MiB
80b2ce317.73 MiB19.75 MiB2.02 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
76d1baf+dirty17.73 MiB20.04 MiB2.31 MiB

Previous results on branch: kw-rn-upgrade-0-72

Startup times

RevisionPlainWith SentryDiff
79d0940316.30 ms323.10 ms6.80 ms

App size

RevisionPlainWith SentryDiff
79d094017.73 MiB19.81 MiB2.07 MiB

@github-actions

github-actionsBot commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1272.14 ms1285.66 ms13.52 ms
Size2.36 MiB2.85 MiB496.86 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
acadc0f+dirty1264.38 ms1290.06 ms25.68 ms
34aba08+dirty1276.78 ms1308.52 ms31.74 ms
ad6c299+dirty1244.76 ms1260.10 ms15.34 ms
3ffcddd+dirty1244.47 ms1264.14 ms19.67 ms
dadc233+dirty1223.20 ms1236.88 ms13.68 ms
d197b5c+dirty1217.61 ms1242.66 ms25.05 ms
15c80ab+dirty1223.74 ms1228.96 ms5.22 ms
70caa60+dirty1218.27 ms1230.30 ms12.03 ms
52a8031+dirty1280.88 ms1289.78 ms8.90 ms
80b2ce3+dirty1265.92 ms1268.60 ms2.69 ms

App size

RevisionPlainWith SentryDiff
acadc0f+dirty2.36 MiB2.83 MiB480.37 KiB
34aba08+dirty2.36 MiB2.85 MiB495.32 KiB
ad6c299+dirty2.36 MiB2.84 MiB488.85 KiB
3ffcddd+dirty2.36 MiB2.84 MiB489.60 KiB
dadc233+dirty2.36 MiB2.84 MiB486.85 KiB
d197b5c+dirty2.36 MiB2.82 MiB462.86 KiB
15c80ab+dirty2.36 MiB2.83 MiB474.49 KiB
70caa60+dirty2.36 MiB2.83 MiB479.27 KiB
52a8031+dirty2.36 MiB2.82 MiB469.44 KiB
80b2ce3+dirty2.36 MiB2.84 MiB486.98 KiB

@github-actions

github-actionsBot commented Jun 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1257.86 ms1266.68 ms8.82 ms
Size2.92 MiB3.41 MiB501.01 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
70caa60+dirty1279.08 ms1281.54 ms2.46 ms
9a3ca65+dirty1276.40 ms1279.14 ms2.74 ms
e2b64fe+dirty1285.78 ms1297.56 ms11.78 ms
d197b5c+dirty1234.80 ms1249.20 ms14.40 ms
15c80ab+dirty1248.41 ms1251.24 ms2.83 ms
0db0c72+dirty1258.88 ms1262.52 ms3.64 ms
b1e8712+dirty1284.11 ms1297.82 ms13.71 ms
8900e1a+dirty1268.36 ms1273.04 ms4.68 ms
76d1baf+dirty1245.00 ms1257.76 ms12.76 ms
52a8031+dirty1255.96 ms1273.00 ms17.04 ms

App size

RevisionPlainWith SentryDiff
70caa60+dirty2.92 MiB3.39 MiB486.04 KiB
9a3ca65+dirty2.92 MiB3.37 MiB464.32 KiB
e2b64fe+dirty2.92 MiB3.41 MiB499.97 KiB
d197b5c+dirty2.92 MiB3.37 MiB464.41 KiB
15c80ab+dirty2.92 MiB3.39 MiB481.56 KiB
0db0c72+dirty2.92 MiB3.40 MiB492.71 KiB
b1e8712+dirty2.92 MiB3.40 MiB494.15 KiB
8900e1a+dirty2.92 MiB3.39 MiB485.96 KiB
76d1baf+dirty2.92 MiB3.38 MiB475.74 KiB
52a8031+dirty2.92 MiB3.38 MiB475.71 KiB

Previous results on branch: kw-rn-upgrade-0-72

Startup times

RevisionPlainWith SentryDiff
79d0940+dirty1258.86 ms1267.82 ms8.96 ms

App size

RevisionPlainWith SentryDiff
79d0940+dirty2.92 MiB3.41 MiB500.99 KiB

@github-actions

github-actionsBot commented Jun 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time262.21 ms318.82 ms56.61 ms
Size7.15 MiB8.07 MiB949.80 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
70caa60+dirty308.83 ms393.06 ms84.23 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms
e2b64fe+dirty258.82 ms304.26 ms45.44 ms
d197b5c+dirty258.75 ms313.61 ms54.86 ms
15c80ab+dirty276.38 ms327.54 ms51.17 ms
0db0c72+dirty335.20 ms351.06 ms15.86 ms
b1e8712+dirty322.55 ms331.84 ms9.29 ms
8900e1a+dirty371.40 ms377.70 ms6.31 ms
76d1baf+dirty339.02 ms408.65 ms69.63 ms
52a8031+dirty330.72 ms358.76 ms28.03 ms

App size

RevisionPlainWith SentryDiff
70caa60+dirty7.15 MiB8.03 MiB901.79 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB
e2b64fe+dirty7.15 MiB8.07 MiB947.16 KiB
d197b5c+dirty7.15 MiB8.09 MiB962.72 KiB
15c80ab+dirty7.15 MiB8.09 MiB966.13 KiB
0db0c72+dirty7.15 MiB8.04 MiB911.02 KiB
b1e8712+dirty7.15 MiB8.04 MiB912.27 KiB
8900e1a+dirty7.15 MiB8.03 MiB901.79 KiB
76d1baf+dirty7.15 MiB8.09 MiB964.41 KiB
52a8031+dirty7.15 MiB8.09 MiB965.95 KiB

Previous results on branch: kw-rn-upgrade-0-72

Startup times

RevisionPlainWith SentryDiff
79d0940+dirty273.83 ms332.56 ms58.73 ms

App size

RevisionPlainWith SentryDiff
79d0940+dirty7.15 MiB8.07 MiB949.80 KiB

@krystofwoldrich

krystofwoldrich commented Jun 26, 2023

Copy link
Copy Markdown
ContributorAuthor

This is ready for review.

@krystofwoldrich
krystofwoldrich merged commit e44fe2d into mainJun 27, 2023
@krystofwoldrich
krystofwoldrich deleted the kw-rn-upgrade-0-72 branch June 27, 2023 09:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@marandanetomarandanetomarandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krystofwoldrich@marandaneto@web-flow