Uh oh!
There was an error while loading. Please reload this page.
Implement crashedLastRun - #4014
Merged
krystofwoldrich merged 9 commits intoAug 26, 2024
Merged
Conversation
janicduplessis
marked this pull request as ready for review
August 9, 2024 21:15
janicduplessis
requested review from
krystofwoldrich and lucas-zimerman
as code ownersAugust 9, 2024 21:15
krystofwoldrich
commented
Aug 12, 2024
Contributor
@janicduplessis Thank you for the PR, we'll review this shortly. |
Uh oh!
There was an error while loading. Please reload this page.
janicduplessisforce-pushed
the
@janic/crash-last-run
branch
4 times, most recently
from
August 15, 2024 17:39
43d82b6 to
95cd530Comparejanicduplessisforce-pushed
the
@janic/crash-last-run
branch
from
August 15, 2024 17:42
95cd530 to
a7b811fComparejanicduplessis
commented
Aug 15, 2024
ContributorAuthor
Updated to return null when the sdk does. Also added it to the sample app. |
krystofwoldrich
commented
Aug 19, 2024
Contributor
Awesome, thank you, I'll review the changes soon. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
krystofwoldrich
commented
Aug 26, 2024
Contributor
I've added simple test for the JS interface, but besides that it looks good. Thank you! |
krystofwoldrich
approved these changes
Aug 26, 2024
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This exposes
crashedLastRunfrom the iOS sdk andisCrashedLastRunfrom the android sdk to react native.It is useful to know if the app crashed in the previous launch.
💡 Motivation and Context
Fixes#2797
💚 How did you test it?
Tested in an app on iOS and Android by making it crash then checking that it returns true on next open, or false if didn't crash before.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps